fix(dashboard-filters): Fixes a overflow issue for filters when many filters are enabled#52178
Merged
fix(dashboard-filters): Fixes a overflow issue for filters when many filters are enabled#52178
Conversation
…filters are enabled
Contributor
|
Reviews (1): Last reviewed commit: "fix(dashboard-filters): Fixes a overflow..." | Re-trigger Greptile |
Contributor
|
Size Change: -181 B (0%) Total Size: 108 MB ℹ️ View Unchanged
|
MattPua
added
the
update-snapshots
arthurdedeus
approved these changes
Mar 24, 2026
Contributor
Visual regression: Storybook UI snapshots updatedChanges: 7 snapshots (7 modified, 0 added, 0 deleted) What this means:
Next steps:
|
Member
Author
|
@adamleithp sorry for pinging you on so many things recently, but wanted to get an opinion on something PR fixes an overflow problem for tiles, that part is fine. It also updates the filter button in general, to not be full width all the time, and instead be fit width basically. Personally i like it better, but I defer to your call. See snapshot examples below 
In the process I also changed it such |
matt-metivier
pushed a commit
that referenced
this pull request
Mar 25, 2026
…filters are enabled (#52178) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When we have many dahsboard filters enabled, the filters bar does not scroll or overflow properly, leading to filters that overflow off the screen.
Closes #52047
Changes
We now overflow correctly
on the most extreme cases
How did you test this code?
Locally.
Publish to changelog?
No.