fix(scenes): guard sessionStorage access to prevent ReferenceError after Jest teardown#52646
Draft
mendral-app[bot] wants to merge 2 commits intomasterfrom
Draft
fix(scenes): guard sessionStorage access to prevent ReferenceError after Jest teardown#52646mendral-app[bot] wants to merge 2 commits intomasterfrom
mendral-app[bot] wants to merge 2 commits intomasterfrom
Conversation
…ter Jest teardown
Contributor
|
Size Change: +338 B (0%) Total Size: 124 MB ℹ️ View Unchanged
|
Contributor
Visual regression: Storybook UI snapshots updatedChanges: 1 snapshots (1 modified, 0 added, 0 deleted) What this means:
Next steps:
|
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sessionStorage.setItemandsessionStorage.getItemcalls inpersistSessionTabsandgetPersistedSessionTabswith try/catch blocksReferenceError: sessionStorage is not definedinsceneLogic.tsx:78— the asyncloadPinnedTabsFromBackendlistener can fire after Jest has torn down the jsdom environment, at which pointsessionStorageis no longer definedCloses insight: https://app.mendral.com/insights/01KMRMSKV913C5J53GYPX9V5A6
Note
Created by Mendral. Tag @mendral-app with feedback or questions.