Add 50000 limit to aggregate survey query results#53451
Merged
Conversation
Generated-By: PostHog Code Task-Id: 7c62a2f6-3302-4f0b-9b0a-b426f3465735
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Size Change: +48 B (0%) Total Size: 127 MB ℹ️ View Unchanged
|
Contributor
Prompt To Fix All With AIThis is a comment left during a code review.
Path: frontend/src/scenes/surveys/utils.ts
Line: 588
Comment:
**Inconsistent limit pattern vs `buildOpenEndedQuery`**
`buildOpenEndedQuery` (line 595) accepts a configurable `limit: number = 50000` parameter and interpolates it as `LIMIT ${limit}`. This function now hardcodes `50000` directly in the query string. The two functions share the same magic number but express it differently, so a future change to the limit would need to be updated in both places.
Consider extracting a shared constant or following the same parameter pattern:
```suggestion
return `SELECT question_id, label, cnt FROM (${branches.join('\nUNION ALL\n')}) LIMIT ${SURVEY_QUERY_LIMIT}`
```
where `const SURVEY_QUERY_LIMIT = 50000` is defined at module scope and reused by both functions.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix(surveys): Add 50000 limit to aggrega..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| } | ||
|
|
||
| return `SELECT question_id, label, cnt FROM (${branches.join('\nUNION ALL\n')})` | ||
| return `SELECT question_id, label, cnt FROM (${branches.join('\nUNION ALL\n')}) LIMIT 50000` |
Contributor
There was a problem hiding this comment.
buildOpenEndedQuery
buildOpenEndedQuery (line 595) accepts a configurable limit: number = 50000 parameter and interpolates it as LIMIT ${limit}. This function now hardcodes 50000 directly in the query string. The two functions share the same magic number but express it differently, so a future change to the limit would need to be updated in both places.
Consider extracting a shared constant or following the same parameter pattern:
Suggested change
| return `SELECT question_id, label, cnt FROM (${branches.join('\nUNION ALL\n')}) LIMIT 50000` | |
| return `SELECT question_id, label, cnt FROM (${branches.join('\nUNION ALL\n')}) LIMIT ${SURVEY_QUERY_LIMIT}` |
where const SURVEY_QUERY_LIMIT = 50000 is defined at module scope and reused by both functions.
Prompt To Fix With AI
This is a comment left during a code review.
Path: frontend/src/scenes/surveys/utils.ts
Line: 588
Comment:
**Inconsistent limit pattern vs `buildOpenEndedQuery`**
`buildOpenEndedQuery` (line 595) accepts a configurable `limit: number = 50000` parameter and interpolates it as `LIMIT ${limit}`. This function now hardcodes `50000` directly in the query string. The two functions share the same magic number but express it differently, so a future change to the limit would need to be updated in both places.
Consider extracting a shared constant or following the same parameter pattern:
```suggestion
return `SELECT question_id, label, cnt FROM (${branches.join('\nUNION ALL\n')}) LIMIT ${SURVEY_QUERY_LIMIT}`
```
where `const SURVEY_QUERY_LIMIT = 50000` is defined at module scope and reused by both functions.
How can I resolve this? If you propose a fix, please make it concise.
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
MattBro
pushed a commit
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
survey aggregate query has no defined limit, causing it to be capped at 100
this fix was attempted in #51897, but i missed this one 🙈
Changes
adds explicit limit to the aggregate query
How did you test this code?
see manual testing notes in ticket: https://posthoghelp.zendesk.com/agent/tickets/52678
Created with PostHog Code