fix(experiments): Show spinner while loading project experiment settings#53884
Merged
jurajmajerik merged 2 commits intomasterfrom Apr 9, 2026
Merged
fix(experiments): Show spinner while loading project experiment settings#53884jurajmajerik merged 2 commits intomasterfrom
jurajmajerik merged 2 commits intomasterfrom
Conversation
Contributor
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
|
Size Change: 0 B Total Size: 128 MB ℹ️ View Unchanged
|
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
lucasheriques
approved these changes
Apr 9, 2026
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The experiment settings page (statistical method, confidence level, recalculation time) flashes default values before the actual team data loads.
Changes
Show a spinner in
ExperimentsSettingswhilecurrentTeamis loading, instead of rendering children that fall back to hardcoded defaults.How did you test this code?
Verified spinner displays while team data loads, then settings render with correct values.