Skip to content

fix(github): Fix duplicate GH integration env var#54305

Merged
Twixes merged 2 commits into
masterfrom
fix-gh-secret
Apr 21, 2026
Merged

fix(github): Fix duplicate GH integration env var#54305
Twixes merged 2 commits into
masterfrom
fix-gh-secret

Conversation

@Twixes
Copy link
Copy Markdown
Member

@Twixes Twixes commented Apr 13, 2026

Problem

Unknowingly duplicated GITHUB_APP_CLIENT_ID as GITHUB_APP_OAUTH_CLIENT_ID in #53767.

Changes

GITHUB_APP_OAUTH_CLIENT_ID →  the pre-existing GITHUB_APP_CLIENT_ID
GITHUB_APP_OAUTH_CLIENT_SECRET → just GITHUB_APP_CLIENT_SECRET

Companion: https://github.com/PostHog/charts/pull/9900

@Twixes Twixes requested a review from a team April 13, 2026 17:59
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 13, 2026

Reviews (1): Last reviewed commit: "Update integration.py" | Re-trigger Greptile

@github-actions
Copy link
Copy Markdown
Contributor

🎭 Playwright report · View test results →

⚠️ 3 flaky tests:

  • Creating a SQL insight with a variable and overriding it on a dashboard (chromium)
  • Save view (chromium)
  • Materialize view pane (chromium)

These issues are not necessarily caused by your changes.
Annoyed by this comment? Help fix flakies and failures and it'll disappear!

@github-actions
Copy link
Copy Markdown
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, please remove the stale label – otherwise this will be closed in another week. If you want to permanently keep it open, use the waiting label.

@github-actions github-actions Bot added the stale label Apr 21, 2026
@Twixes Twixes merged commit 436879e into master Apr 21, 2026
206 of 207 checks passed
@Twixes Twixes deleted the fix-gh-secret branch April 21, 2026 16:54
@deployment-status-posthog
Copy link
Copy Markdown

deployment-status-posthog Bot commented Apr 21, 2026

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-04-21 17:17 UTC Run
prod-us ✅ Deployed 2026-04-21 17:30 UTC Run
prod-eu ✅ Deployed 2026-04-21 17:37 UTC Run

thmsobrmlr pushed a commit that referenced this pull request Apr 21, 2026
## Problem

Unknowingly duplicated `GITHUB_APP_CLIENT_ID` as `GITHUB_APP_OAUTH_CLIENT_ID` in  #53767.

## Changes

`GITHUB_APP_OAUTH_CLIENT_ID` →  the pre-existing `GITHUB_APP_CLIENT_ID`
`GITHUB_APP_OAUTH_CLIENT_SECRET` → just `GITHUB_APP_CLIENT_SECRET`

Companion: PostHog/charts#9900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants