feat(customer-analytics): add calculation selector and adopt generated API types#54347
Merged
arthurdedeus merged 6 commits intomasterfrom Apr 22, 2026
Merged
Conversation
Contributor
Author
Contributor
|
Size Change: +5.42 kB (0%) Total Size: 130 MB
ℹ️ View Unchanged
|
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Apr 13, 2026
Contributor
Prompt To Fix All With AIThis is a comment left during a code review.
Path: frontend/src/scenes/settings/environment/usageMetricsConfigLogic.ts
Line: 21
Comment:
**Superfluous re-export**
`GroupUsageMetricApi` is no longer imported from this logic file by any consumer — `UsageMetricsConfig.tsx` now imports directly from the generated schema, and `NotebookNodeUsageMetrics.tsx` only imports the logic function itself. This dead re-export violates the "no superfluous parts" simplicity rule.
```suggestion
```
(Remove the line entirely.)
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: frontend/src/scenes/settings/environment/usageMetricsConfigLogic.ts
Line: 83-88
Comment:
**Type assertion incorrectly adds `id` back**
`payload` is `Omit<GroupUsageMetricApi, 'id'>`, but it is cast to `GroupUsageMetricApi` whose `id: string` is required. TypeScript accepts the `as` assertion without verifying the missing field, so the generated `groupsTypesMetricsCreate` function's parameter type `NonReadonly<GroupUsageMetricApi>` is technically violated. A safer assertion that accurately reflects the runtime shape would be:
```suggestion
const newMetric = await groupsTypesMetricsCreate(
values.currentProjectId,
GROUP_TYPE_INDEX,
payload as NonReadonly<Omit<GroupUsageMetricApi, 'id'>> as NonReadonly<GroupUsageMetricApi>
)
```
Or alternatively, the generated function signature for create could be widened to accept `Omit<NonReadonly<GroupUsageMetricApi>, 'id'>` if regenerating.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "feat(customer-analytics): add calculatio..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
arthurdedeus
force-pushed
the
posthog-code/usage-metric-sum-aggregation-frontend
branch
from
9b7a48c to
3e24102
Compare
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
arthurdedeus
force-pushed
the
posthog-code/usage-metric-sum-aggregation-backend
branch
from
6d6a4ad to
e0673f4
Compare
arthurdedeus
changed the base branch from
posthog-code/usage-metric-sum-aggregation-backend
to
graphite-base/54347
arthurdedeus
force-pushed
the
graphite-base/54347
branch
from
e0673f4 to
659b6d3
Compare
arthurdedeus
force-pushed
the
posthog-code/usage-metric-sum-aggregation-frontend
branch
from
73ce462 to
bbd12a4
Compare
arthurdedeus
changed the base branch from
graphite-base/54347
to
posthog-code/usage-metric-sum-aggregation-backend
Contributor
Prompt To Fix All With AIThis is a comment left during a code review.
Path: frontend/src/scenes/settings/environment/usageMetricsConfigLogic.ts
Line: 21
Comment:
**Superfluous `export` on `UsageMetricFormData`**
`UsageMetricFormData` is only used within this file (`NEW_USAGE_METRIC`, `addUsageMetric`, `updateUsageMetric`) and nothing imports it externally. The `export` keyword is superfluous per the "no superfluous parts" simplicity rule.
```suggestion
type UsageMetricFormData = Omit<GroupUsageMetricApi, 'id'> & { id?: string }
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (2): Last reviewed commit: "fix(customer-analytics): fix type error ..." | Re-trigger Greptile |
lricoy
approved these changes
Apr 22, 2026
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
The PR imports GroupUsageMetricApi and groupsTypesMetrics* API functions from products/customer_analytics/frontend/generated/api[.schemas], but those exports only exist in products/metrics/frontend/generated/. The customer_analytics generated files contain only CustomerJourneyApi and related types. Additionally, the existing GroupUsageMetricApi in the metrics schema lacks the math and math_property fields this code uses, indicating the backend serializer and OpenAPI types were never regenerated. This PR would fail TypeScript compilation.
arthurdedeus
force-pushed
the
posthog-code/usage-metric-sum-aggregation-backend
branch
from
659b6d3 to
9eef96d
Compare
arthurdedeus
force-pushed
the
posthog-code/usage-metric-sum-aggregation-frontend
branch
from
bbd12a4 to
4bbfb67
Compare
Base automatically changed from
posthog-code/usage-metric-sum-aggregation-backend
to
master
April 22, 2026 17:50
…d API types Generated-By: PostHog Code Task-Id: 887010a6-d3c0-4a87-b260-bdbc5cb48df1
Generated-By: PostHog Code Task-Id: 887010a6-d3c0-4a87-b260-bdbc5cb48df1
Generated-By: PostHog Code Task-Id: 887010a6-d3c0-4a87-b260-bdbc5cb48df1
Generated-By: PostHog Code Task-Id: 887010a6-d3c0-4a87-b260-bdbc5cb48df1
arthurdedeus
force-pushed
the
posthog-code/usage-metric-sum-aggregation-frontend
branch
from
185891e to
e3593d6
Compare
arthurdedeus
deleted the
posthog-code/usage-metric-sum-aggregation-frontend
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The usage metrics config UI has no way to select sum-based aggregation (added in #54346), and the frontend uses handwritten types and manual API calls instead of generated ones.
Changes
api.get/create/update/deletecalls to generatedgroupsTypesMetrics*functionsUsageMetricFormDatafrom the generatedGroupUsageMetricApitypeGroupUsageMetricViewSettypes tocustomer_analyticsgenerated outputHow did you test this code?
Existing test suite. Frontend changes are type-safe against the generated API types.
Publish to changelog?
No
Docs update
N/A
🤖 LLM context
Agent-authored PR. Frontend half of a stacked PR — depends on #54346 for the backend model changes.
Created with PostHog Code