Skip to content

feat(llma): add evaluation reports frontend #54366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewm4894 wants to merge 1 commit into
base: andy/llma-eval-reports-3-delivery-workflows
Choose a base branch
from
Open

feat(llma): add evaluation reports frontend #54366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions frontend/src/lib/constants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,7 @@ export const FEATURE_FLAGS = {
LLM_ANALYTICS_TRACE_NAVIGATION: 'llm-analytics-trace-navigation', // owner: #team-llm-analytics
LLM_ANALYTICS_EVALUATIONS_CUSTOM_MODELS: 'llm-analytics-evaluations-custom-models', // owner: #team-llm-analytics
LLM_ANALYTICS_EVALUATIONS_HOG_CODE: 'llm-analytics-evaluations-hog-code', // owner: #team-llm-analytics
LLM_ANALYTICS_EVALUATIONS_REPORTS: 'llm-analytics-evaluations-reports', // owner: #team-llm-analytics
LLM_ANALYTICS_EVALUATIONS_SUMMARY: 'llm-analytics-evaluations-summary', // owner: #team-llm-analytics
LLM_ANALYTICS_SESSION_SUMMARIZATION: 'llm-analytics-session-summarization', // owner: #team-llm-analytics
LLM_ANALYTICS_CLUSTERS_TAB: 'llm-analytics-clusters-tab', // owner: #team-llm-analytics
Expand Down Expand Up @@ -392,7 +393,6 @@ export const FEATURE_FLAGS = {
ONBOARDING_WIZARD_PROMINENCE: 'onboarding-wizard-prominence', // owner: #team-growth multivariate=control,wizard-hero,wizard-tab,wizard-only
ONBOARDING_WIZARD_INSTALLATION_IMPROVED_COPY: 'onboarding-wizard-installation-improved-copy', // owner: @fercgomes #team-growth multivariate=control,test
ONBOARDING_MOBILE_INSTALL_HELPER: 'onboarding-mobile-install-helper', // owner: @fercgomes #team-growth multivariate=control,test — target $device_type=Mobile at the flag level
Comment on lines 393 to 395
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore onboarding value-prop feature flag constant

Removing ONBOARDING_DATA_WAREHOUSE_VALUE_PROP from FEATURE_FLAGS breaks the onboarding experiment lookup used in OnboardingDataWarehouseSourcesStep (useFeatureFlag('ONBOARDING_DATA_WAREHOUSE_VALUE_PROP', ...)), so the variant branches can no longer activate and users are forced into the fallback flow. If type-checking is bypassed this becomes a silent runtime regression (FEATURE_FLAGS[flag] resolves to undefined), and if type-checking runs it blocks the build.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

@andrewm4894 andrewm4894 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a rebase artifact — the removal of ONBOARDING_DATA_WAREHOUSE_VALUE_PROP (and SURVEYS_TOOLBAR) is not intentional. These were dropped during a conflict resolution when stacking. I'll restore them. Fix incoming.

ONBOARDING_DATA_WAREHOUSE_VALUE_PROP: 'onboarding-data-warehouse-value-prop', // owner: @fercgomes #team-growth multivariate=control,table,query
OWNER_ONLY_BILLING: 'owner-only-billing', // owner: @pawelcebula #team-billing
POST_ONBOARDING_MODAL_EXPERIMENT: 'post-onboarding-modal-experiment', // owner: @fercgomes #team-growth multivariate=control,test
PASSKEY_SIGNUP_ENABLED: 'passkey-signup-enabled', // owner: @reecejones #team-platform-features
Expand Down Expand Up @@ -445,7 +445,6 @@ export const FEATURE_FLAGS = {
SURVEYS_FORM_BUILDER: 'surveys-form-builder', // owner: @adboio #team-surveys
SURVEY_HEADLINE_SUMMARY: 'survey-headline-summary', // owner: @adboio #team-surveys
SURVEYS_INSIGHT_BUTTON_EXPERIMENT: 'ask-users-why-ai-vs-quickcreate', // owner: @adboio #team-surveys multivariate=true
SURVEYS_TOOLBAR: 'surveys-toolbar', // owner: @fcgomes
SURVEYS_WEB_ANALYTICS_CROSS_SELL: 'surveys-in-web-analytics', // owner: @adboio #team-surveys
TASK_SUMMARIES: 'task-summaries', // owner: #team-llm-analytics
TASK_TOOL: 'phai-task-tool', // owner: @kappa90 #team-posthog-ai
Expand Down
27 changes: 27 additions & 0 deletions products/llm_analytics/frontend/evaluations/LLMAnalyticsEvaluation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ import { modelPickerLogic } from '../modelPickerLogic'
import { providerKeyStateIssueDescription, providerLabel } from '../settings/providerKeyStateUtils'
import { EvaluationCodeEditor } from './components/EvaluationCodeEditor'
import { EvaluationPromptEditor } from './components/EvaluationPromptEditor'
import { EvaluationReportConfig } from './components/EvaluationReportConfig'
import { EvaluationReportsTab } from './components/EvaluationReportsTab'
import { EvaluationRunsTable } from './components/EvaluationRunsTable'
import { EvaluationTriggers } from './components/EvaluationTriggers'
import { LLMEvaluationLogicProps, llmEvaluationLogic } from './llmEvaluationLogic'
Expand Down Expand Up @@ -297,6 +299,18 @@ export function LLMAnalyticsEvaluation(): JSX.Element {
</div>
),
},
!isNewEvaluation &&
!!featureFlags[FEATURE_FLAGS.LLM_ANALYTICS_EVALUATIONS_REPORTS] && {
key: 'reports',
label: 'Reports',
'data-attr': 'llma-evaluation-reports-tab',
content: (
<EvaluationReportsTab
evaluationId={evaluation.id}
onConfigureClick={() => setActiveTab('configuration')}
/>
),
},
{
key: 'configuration',
label: 'Configuration',
Expand Down Expand Up @@ -453,7 +467,20 @@ export function LLMAnalyticsEvaluation(): JSX.Element {
</p>
<EvaluationTriggers />
</div>

{/* Scheduled Reports (inline config for new evaluations) */}
{isNewEvaluation &&
featureFlags[FEATURE_FLAGS.LLM_ANALYTICS_EVALUATIONS_REPORTS] && (
<EvaluationReportConfig evaluationId="new" />
)}
</Form>

{/* Scheduled Reports (for existing evaluations, outside the form) */}
{!isNewEvaluation && featureFlags[FEATURE_FLAGS.LLM_ANALYTICS_EVALUATIONS_REPORTS] && (
<div className="mt-6">
<EvaluationReportConfig evaluationId={evaluation.id} />
</div>
)}
</div>
),
},
Expand Down
Loading
Loading