Merged
Conversation
Contributor
|
Size Change: +12.6 kB (+0.01%) Total Size: 130 MB
ℹ️ View Unchanged
|
Contributor
Prompt To Fix All With AIThis is a comment left during a code review.
Path: frontend/src/queries/nodes/DataVisualization/DataVisualization.tsx
Line: 252-253
Comment:
**Intentional but asymmetric condition vs. line graph**
`_yData` here uses `seriesBreakdownData.seriesData.length` while the equivalent line-graph path (lines 237–238) uses `seriesBreakdownData.xData.data.length` for both `_xData` and `_yData`. The asymmetry is safe in practice because `buildPieSlices` detects breakdown series via `isBreakdownSeries` and ignores `xData` on that path — but a future reader may find the divergence surprising. A brief comment noting the intent (breakdown y-data can be used for pie charts independent of x-breakdown data) would make the difference self-documenting.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "feat(sql): pie charts" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
georgemunyoro
approved these changes
Apr 17, 2026
Collaborator
Author
|
the only broken ci error is a known flake (hogql with_ties issue), so merging it in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We don't have all the visualizations we'd like in the SQL editor
Changes
Add pie charts
How did you test this code?
👀
Publish to changelog?
sure
Docs update
why not