fix(workflows): add observability for action deduplication blocks#55282
Merged
meikelmosby merged 1 commit intomasterfrom Apr 21, 2026
Merged
fix(workflows): add observability for action deduplication blocks#55282meikelmosby merged 1 commit intomasterfrom
meikelmosby merged 1 commit intomasterfrom
Conversation
Add a Prometheus counter and structured logging when the dedup check blocks a workflow action execution. This helps diagnose cases where invocations are unexpectedly blocked as duplicates. - hogflow_action_dedup_blocked_total counter (no high-cardinality labels) - Structured logger.warn with both invocation IDs, event UUID, action details - User-facing log now includes the existing invocation ID for cross-reference Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Prompt To Fix All With AIThis is a comment left during a code review.
Path: nodejs/src/cdp/services/hogflows/hogflow-executor.service.ts
Line: 487-494
Comment:
**No application-level metric emitted for dedup-blocked invocations**
When an early exit occurs (line 317–332), an application-level metric is pushed onto `earlyExitResult.metrics` so the analytics pipeline records a per-team/per-flow occurrence. The new dedup-blocked path only increments the Prometheus counter — no metric entry is pushed onto `dedupResult.metrics`. This means blocked duplicates won't appear in any team-level workflow metrics dashboard, only in the aggregate Prometheus counter.
Consider adding a `'filtered'` (or a new `'deduplicated'`) metric push here for parity with the early-exit path:
```typescript
this.trackActionMetric(dedupResult, currentAction, 'filtered')
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix(workflows): add observability for ac..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
dmarchuk
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Prometheus counter and logging when the dedup check blocks a workflow action execution. This helps diagnose cases where invocations are unexpectedly blocked as duplicates.