fix(dashboards): display warning for ignored properties#55474
Merged
thmsobrmlr merged 6 commits intomasterfrom Apr 21, 2026
Merged
fix(dashboards): display warning for ignored properties#55474thmsobrmlr merged 6 commits intomasterfrom
thmsobrmlr merged 6 commits intomasterfrom
Conversation
Collaborator
Author
Contributor
|
Size Change: +1.61 kB (0%) Total Size: 129 MB ℹ️ View Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Prompt To Fix All With AIThis is a comment left during a code review.
Path: frontend/src/lib/components/Cards/InsightCard/InsightDetails.tsx
Line: 355
Comment:
**Tooltip wording may mislead users**
The tooltip says "Insights with a data warehouse series do not support filters." but the limitation is specifically about **dashboard filter overrides** not being applied — the insight's own embedded properties are unaffected. A user reading this might incorrectly conclude that no filters can ever be set on a DWH-backed insight.
```suggestion
<Tooltip title="Filter overrides are not applied. Insights with a data warehouse series do not support dashboard filter overrides.">
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix(dashboards): display warning for ign..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Collaborator
Author
Merge activity
|
thmsobrmlr
changed the base branch from
fix_dashboards_do_not_apply_properties_to_insights_with_dwh_series
to
graphite-base/55474
thmsobrmlr
deleted the
fix_dashboards_display_warning_for_ignored_properties
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We started ignoring properties from dashboard overrides for insights with data warehouse series in #55269, but it's not transparent for users.
Changes
Add a warning to the details on the card:
I also tried other approaches, like a more visible one on the card directly, but liked the above more:
How did you test this code?
Manual testing