feat(logs): add SQL view and editor to LogsScene#57410
Merged
jonmcwest merged 1 commit intoMay 5, 2026
Merged
Conversation
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
products/logs/frontend/components/LogsSqlEditor/LogsSqlEditor.tsx:6-19
**SQL editor query state lost on tab switch**
`useState` is local to the component instance, so when the user navigates away from the SQL tab the component unmounts (see `{activeTab === 'sql' && showSqlView && <LogsSqlEditor />}`) and the query resets to `SELECT * FROM logs LIMIT 10` on return. For an SQL editor where users compose longer queries this is a noticeable UX regression. Moving the query into a kea logic (similar to how the rest of the Logs scene state is managed) would preserve it across tab switches.
Reviews (1): Last reviewed commit: "feat(logs): add SQL view and editor to L..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
|
Size Change: +3.02 kB (0%) Total Size: 141 MB 📦 View Changed
ℹ️ View Unchanged
|
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
The new LogsSqlEditor uses useState for query state in a component that unmounts on tab switch, causing the SQL query to reset every time the user navigates away. An unresolved bot comment flags this as a valid UX concern. Additionally, the project's coding conventions (AGENTS.md) explicitly say to avoid React hooks and use kea logic instead when a kea logic file exists — which it does here (logsSceneLogic). The concern is unaddressed in the current diff.
jonmcwest
force-pushed
the
05-03-feat_logs_add_sql_view_and_editor_to_logsscene
branch
2 times, most recently
from
b4f5f68 to
6d25b38
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The bot reviews flagged a useState concern from an older commit, but the current code uses kea logic throughout and correctly preserves SQL editor state across tab switches via the keepSqlEditorMounted/cache pattern in logsSceneLogic. The feature is behind a flag and the author is on the owning team — no showstoppers.
jonmcwest
force-pushed
the
05-03-feat_logs_add_sql_view_and_editor_to_logsscene
branch
from
6d25b38 to
5d2c557
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
…c, preserving state across navigation
jonmcwest
force-pushed
the
05-03-feat_logs_add_sql_view_and_editor_to_logsscene
branch
from
5d2c557 to
762ebf9
Compare
Contributor
There was a problem hiding this comment.
The useState concern from older-commit bot reviews is not present in the current code — state is managed through kea's sqlEditorLogic, and the keepSqlEditorMounted cache pattern in logsSceneLogic correctly preserves query state across tab switches. The feature is entirely behind a feature flag, no API contracts or data models are changed, and the author is on the owning team.
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users working with logs need a way to run custom SQL queries directly against log data without leaving the Logs scene. This provides a more flexible, power-user interface for exploring logs beyond the standard viewer.
Changes
Adds a new SQL tab to the Logs scene, gated behind the
LOGS_SQL_VIEWfeature flag. The tab renders an embedded SQL editor pre-populated withSELECT * FROM logs LIMIT 10, giving users a full HogQL editor experience.LOGS_SQL_VIEWfeature flag constant'sql'as a validLogsSceneActiveTabLogsSqlEditorcomponent that initializes asqlEditorLogicinstance in embedded mode, pre-fills the query against thelogstable, and keeps the editor mounted vialogsSceneLogiccache to avoid re-initialization on tab switchesLogsSceneTabbedContentbehind the feature flagkeepSqlEditorMountedaction and correspondingbeforeUnmountcleanup to properly manage the lifecycle of the embedded SQL editor logic"Logs"scene to query tagging so queries from this scene are correctly attributed to the logs productHow did you test this code?
Enable the
logs-sql-viewfeature flag and navigate to the Logs scene — a new SQL tab should appear. Clicking it renders the HogQL editor pre-filled with a query against thelogstable.Publish to changelog?
Yes
Docs update
Yes — explain that logs can be queried via SQL using the new SQL tab in the Logs scene.