revert: "fix(shared-views): skip API calls that always 401 in shared/exported views"#57814
Merged
pauldambra merged 1 commit intomasterfrom May 6, 2026
Merged
Conversation
…xported …" This reverts commit d9c5aa3.
sakce
approved these changes
May 6, 2026
vdekrijger
approved these changes
May 6, 2026
Contributor
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
Contributor
|
Reviews (1): Last reviewed commit: "Revert "fix(shared-views): skip API call..." | Re-trigger Greptile |
Contributor
|
Size Change: -30.6 kB (-0.03%) Total Size: 98.4 MB 📦 View Changed
ℹ️ View Unchanged
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5587878308
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .filter((id): id is number => !!id) | ||
|
|
||
| if (insightIds.length > 0 && values.currentTeamId && !isSharedView()) { | ||
| if (insightIds.length > 0 && values.currentTeamId) { |
There was a problem hiding this comment.
ExporterDashboardScene mounts dashboardLogic in DashboardPlacement.Public, but this condition now posts to /api/environments/{id}/insights/viewed for every shared dashboard load. Public/shared viewers are often unauthenticated, so this request reliably returns 401 there, and because it is fired as void api.create(...) with no rejection handler it creates repeated client-side error noise instead of being a no-op. Keep a shared/public-mode guard (or placement check) before sending this write call.
Useful? React with 👍 / 👎.
Comment on lines
973
to
975
| loadPinnedTabsFromBackend: async () => { | ||
| if (isSharedView()) { | ||
| return | ||
| } | ||
| try { | ||
| const response = await api.get<{ |
There was a problem hiding this comment.
This shared-view short-circuit was removed, so sceneLogic now calls api/user_home_settings/@me/ even when rendered via exported/shared insights. ExportedInsight mounts insightLogic, and insightLogic connects sceneLogic, so anonymous shared viewers hit a user-scoped endpoint that cannot succeed and generate avoidable 401 failures on mount. The loader should still bail out in shared/export contexts.
Useful? React with 👍 / 👎.
pauldambra
deleted the
revert-57670-posthog-code/skip-shared-view-api-calls
branch
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #57670
errors but we don't know why