Skip to content

feat(product-analytics): roll out validation for test account filters for mcp/api#58320

Merged
thmsobrmlr merged 2 commits into
masterfrom
roll-out-test-account-validation
May 18, 2026
Merged

feat(product-analytics): roll out validation for test account filters for mcp/api#58320
thmsobrmlr merged 2 commits into
masterfrom
roll-out-test-account-validation

Conversation

@thmsobrmlr
Copy link
Copy Markdown
Collaborator

Problem

We added validations for test account filters, but couldn't roll them out due to invalid entries in production.

Changes

These have now been fixed, let's roll the validations out.

How did you test this code?

n/a

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 12, 2026

Reviews (1): Last reviewed commit: "feat(product-analytics): roll out valida..." | Re-trigger Greptile

@thmsobrmlr thmsobrmlr added the stamphog Request AI review from stamphog label May 12, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple rollout of existing guarded validation — removes a feature flag so previously opt-in strict validation of test account filters is now always enforced. The validation logic itself is unchanged; tests are updated correctly to match. No data model, dependency, or security concerns.

@github-actions
Copy link
Copy Markdown
Contributor

🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down.

Add the run-playwright label if you want an E2E sweep before merging — CI will pick it up automatically.

Most PRs don't need this. Real regressions still get caught on master and fix-forward.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 12, 2026

Reviews (2): Last reviewed commit: "Merge branch 'master' into roll-out-test..." | Re-trigger Greptile

@thmsobrmlr thmsobrmlr merged commit 637c0b5 into master May 18, 2026
209 checks passed
@thmsobrmlr thmsobrmlr deleted the roll-out-test-account-validation branch May 18, 2026 10:12
@deployment-status-posthog
Copy link
Copy Markdown

deployment-status-posthog Bot commented May 18, 2026

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-05-18 11:46 UTC Run
prod-us ✅ Deployed 2026-05-18 11:57 UTC Run
prod-eu ✅ Deployed 2026-05-18 12:14 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stamphog Request AI review from stamphog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant