feat(replay): return partial results from group session summaries#58849
Merged
Conversation
Contributor
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
Contributor
|
Size Change: -35.6 kB (-0.03%) Total Size: 118 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
|
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
fasyy612
requested review from
a team,
TueHaulund,
arnohillen,
ksvat and
nicowaltz
and removed request for
a team
TueHaulund
reviewed
May 19, 2026
| patterns_assignments_list_of_lists | ||
| ): | ||
| # Abort only on total chunk failure; partial assignments still produce a useful patterns report. | ||
| if not patterns_assignments_list_of_lists: |
Contributor
There was a problem hiding this comment.
So now we only raise on total failure which is the whole point but don't we want to at least signal that something went wrong on partial failure?
Contributor
Author
There was a problem hiding this comment.
good point 🤔 I'll add something for partial failure as well
TueHaulund
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Group session summaries used to abort entirely once more than half of the per-session jobs failed mid-flight, after a long wait, users got a 500 with nothing to show and no signal about which sessions failed or why. This change preserves whatever work succeeded and surfaces the rest.
Changes
SessionGroupSummary.run_metadata.failed_sessions./summarize/and the Max chat tool both exposefailed_sessionsso callers can distinguish partial from clean runs. The chat tool prepends a short note to the stringified summary so Max mentions partials in its reply rather than claiming a clean run.PartialResultBannerabove the patterns list, collapsed by default, expanding shows dropped sessions grouped by category with links back to the player.capture_session_summary_generatedgets partial +failed_session_countproperties so dashboards can split clean vs degraded successes.How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Publish to changelog?
Docs update
🤖 Agent context