chore(ml/replay): nuke session replay features tables#59044
Merged
Conversation
Contributor
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
Contributor
|
Reviews (1): Last reviewed commit: "update max_migrations" | Re-trigger Greptile |
orian
reviewed
May 20, 2026
| # 4. Read-side Distributed table. | ||
| run_sql_with_exceptions( | ||
| "DROP TABLE IF EXISTS session_replay_features", | ||
| node_roles=[NodeRole.AUX], |
Contributor
There was a problem hiding this comment.
if running one query on multiple node_roles, just use
node_roles = [NodeRole.AUX, NodeRole.DATA]
orian
approved these changes
May 20, 2026
…table # Conflicts: # posthog/clickhouse/migrations/max_migration.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Migration 252 broke the
session_replay_featurestable and left orphaned views.Changes
Nukes all
session_replay_featurestables in order to clean the slate for recreating them. This is OK because the session feature recorder is currently DISABLED and will remain so until the tables are recreated.