ci(frontend): add services/mcp to path filter for Oxlint coverage#59249
Merged
rafaeelaudibert merged 1 commit intoMay 20, 2026
Conversation
services/mcp/ TypeScript files are subject to Oxlint rules but changes in that path did not trigger the Frontend formatting job on PRs (only on post-merge push). This allowed lint errors to slip through to master. Add services/mcp/** to both frontend and frontend_code path filters so Oxlint runs on PRs touching the MCP service.
rafaeelaudibert
approved these changes
May 20, 2026
Contributor
|
Reviews (1): Last reviewed commit: "ci(frontend): add services/mcp to path f..." | Re-trigger Greptile |
Contributor
|
Size Change: 0 B Total Size: 118 MB ℹ️ View Unchanged
|
sakce
added a commit
that referenced
this pull request
May 20, 2026
The import was orphaned when its only call site moved out of this file; master Frontend CI started flagging it after #59249 added services/mcp to the oxlint path filter. Generated-By: PostHog Code Task-Id: d18452f5-e7e1-4358-b35b-3bb3baa6ab13
danielcarletti
added a commit
that referenced
this pull request
May 20, 2026
- Address greptile review: spread warehouseColumns[0] in non-postgres flat table instead of redefining the checkbox-cell render. - Drop unused `getToolDefinition` import in tool-catalog.ts now that services/mcp is covered by the oxlint path filter (#59249). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
aspicer
added a commit
that referenced
this pull request
May 20, 2026
Singular getToolDefinition was imported alongside getToolDefinitions but never used. Once #59249 added services/mcp/ to oxlint's path filter, the unused import started failing Frontend CI on master and every PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
services/mcp/**to thefrontendandfrontend_codepath filters inci-frontend.ymlso that PRs touching MCP service files trigger Oxlint linting before merge.Context
Commit d870696 introduced 5 Oxlint errors in
services/mcp/that weren't caught pre-merge because the frontend CI path filter didn't include that directory. The lint job only ran post-merge on thepushevent (which doesn't use path filters), breaking master.Insight: https://app.mendral.com/insights/01KS37VAXJ8RAYC6ZNV7099MHQ
Note
Created by Mendral. Tag @mendral-app with feedback or questions.