fix(analytics-platform): disable INSERT quorum in local dev so lazy precompute does not hang#59250
Merged
Merged
Conversation
…recompute does not hang
robbie-c
approved these changes
May 20, 2026
Contributor
|
Reviews (1): Last reviewed commit: "fix(analytics-platform): disable INSERT ..." | Re-trigger Greptile |
jabahamondes
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Local dev runs against a single-replica ClickHouse, but the lazy computation framework hardcodes
insert_quorum: \"auto\"on every INSERT. On a single-node setup, ClickHouse writes immediately but still blocks on the quorum protocol — the INSERT then hits the 600smax_execution_timeand dies with:Every fresh lazy precompute request hangs for 10 minutes locally, fails, and falls through to the live path. Tests already had a special case for this (
PREAGGREGATION_INSERT_QUORUM = 0 if TEST else "auto"), butDEBUGmode didn't.Changes
Extend the existing TEST exemption to also cover
DEBUG=True. Prod (DEBUG=False,TEST=False) behavior is unchanged —autostill waits for majority quorum on multi-replica clusters.How did you test this code?
I'm an agent — no manual UI testing claimed.
usedLazyPrecompute=Truein the response. Surfaced while debugging #59075.hogli test products/analytics_platform/backend/lazy_computation/tests/test_lazy_computation_executor.py→ 110 passed.Publish to changelog?
no
🤖 Agent context
Agent-authored. Found by following the chain "INSERT hangs" → log says "Unknown quorum status" → single-node CH can't satisfy quorum → existing exemption already exists for
TEST, just needs to also apply toDEBUG. Same shape and justification as the originalTESTguard.