chore(error-tracking): remove error-tracking-insights feature flag guard#59376
Conversation
The insights tab is fully released, so the flag check is no longer needed. Generated-By: PostHog Code Task-Id: 64aacacc-50fe-4d9d-b366-5f7f8ec109ca
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
|
Size Change: -6.77 kB (-0.01%) Total Size: 116 MB 📦 View Changed
ℹ️ View Unchanged
|
The flag constant had no remaining references in the frontend and spike alerting is fully released. Generated-By: PostHog Code Task-Id: 64aacacc-50fe-4d9d-b366-5f7f8ec109ca
|
Reviews (1): Last reviewed commit: "chore(error-tracking): remove unused err..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
Removes the now-redundant error-tracking-insights feature-flag gate so the Error Tracking “Insights” tab is always available, and cleans up the unused feature flag constant.
Changes:
- Always render the “Insights” tab in the Error Tracking scene (removes
useFeatureFlag('ERROR_TRACKING_INSIGHTS')guard). - Remove
ERROR_TRACKING_INSIGHTSfrom theFEATURE_FLAGSconstants map.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| products/error_tracking/frontend/scenes/ErrorTrackingScene/ErrorTrackingScene.tsx | Removes the feature-flag conditional and always includes the Insights tab in the scene’s tabs list. |
| frontend/src/lib/constants.tsx | Deletes the ERROR_TRACKING_INSIGHTS entry from FEATURE_FLAGS now that it’s no longer referenced. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|
Problem
The
error-tracking-insightsfeature flag is fully released, so the conditional guard around the Insights tab in the error tracking scene is dead weight.Changes
useFeatureFlag('ERROR_TRACKING_INSIGHTS')check inErrorTrackingScene.tsxand always render the Insights tab.ERROR_TRACKING_INSIGHTSconstant fromfrontend/src/lib/constants.tsx.How did you test this code?
I'm an agent — I did not run the app manually. No automated tests were added or run for this purely conditional-removal change.
Publish to changelog?
no
Docs update
No docs change needed.
🤖 Agent context
Authored by PostHog Code on behalf of @ablaszkiewicz, who requested removing the feature flag guard now that the insights tab is fully rolled out. I located the flag's only conditional use in
ErrorTrackingScene.tsx, inlined the tab definition unconditionally, and removed the constant fromfrontend/src/lib/constants.tsxafter verifying no other references remained via grep. The othererror-tracking-insights-*string occurrences inChartCard.tsxare unrelated logic keys, not the flag.Created with PostHog Code