fix(error-tracking): stop reporting advisory reverse proxy check failures#59639
Draft
posthog[bot] wants to merge 1 commit into
Draft
fix(error-tracking): stop reporting advisory reverse proxy check failures#59639posthog[bot] wants to merge 1 commit into
posthog[bot] wants to merge 1 commit into
Conversation
…ures The HogQL probe in `reverseProxyCheckerLogic` is purely advisory — it only exists to auto-complete the "Set up reverse proxy" onboarding task. The catch block already swallows the failure so it does not show a user-visible toast, but it was also re-emitting it via `posthog.captureException`, which created a new error tracking issue every time a transient ClickHouse query failed. There is no user-facing impact when this probe fails, so the capture only generates noise. Drop the capture entirely (and the now-unused `posthog` import), and invert the existing regression test to assert that `captureException` is not called on a ClickHouse failure. Generated-By: PostHog Code Task-Id: cc76d54a-5506-4253-82e9-afc2e1da1af0
Contributor
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
Contributor
|
Size Change: +6.77 kB (+0.01%) Total Size: 119 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, please remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The HogQL probe in
reverseProxyCheckerLogicis purely advisory — it only exists to auto-complete the "Set up reverse proxy" onboarding task. PR #59227 wrapped the probe in atry/catchto stop a user-visible "A server error occurred" toast on every scene that mountsProductSetupButton, which was the right call.The same change also added
posthog.captureException(...)inside the catch, which created a new error tracking issue every time a transient ClickHouse query failed. The check runs fromProductSetupButtonandwebAnalyticsHealthLogic, so even a low background rate of ClickHouse failures keeps adding occurrences to a single issue with no user-facing impact and no actionable signal — the displayed error is just the wrappedcausefromapi.queryHogQL.Changes
posthog.captureExceptioncall from the catch infrontend/src/lib/components/ReverseProxyChecker/reverseProxyCheckerLogic.ts(and drop the now-unusedposthog-jsimport). The catch still swallows the error so kea-loaders does not surface a toast.reverseProxyCheckerLogic.test.tsto assert thatposthog.captureExceptionis not called when the HogQL endpoint returns a 500. The toast-suppression assertion is unchanged.How did you test this code?
I'm an agent. I made the change but did not run the Jest suite locally —
node_modulesis not installed in this environment. The test change is mechanical: the existing test already mocks a 500 from the HogQL endpoint and spies onposthog.captureException; I flipped the assertion fromtoHaveBeenCalledWith(...)tonot.toHaveBeenCalled()to match the new behavior. CI will exercise it.Publish to changelog?
no
Docs update
No docs change needed — this is a noise reduction in an internal advisory check.
🤖 Agent context
Authored by PostHog Code in response to an error-tracking signal report. Investigation:
beac872e…ef5f(2 occurrences / 1 distinct_id in 7 days) with a stack throughloadHasReverseProxy→api.queryHogQL.captureExceptioncall to PR fix(onboarding): swallow reverse proxy check errors instead of toasting #59227 (commita8959a7). The catch block's comment already declared the check "advisory (used only to auto-complete a setup task)", which made the capture self-contradictory: we explicitly do not want users to see this failure, yet we were reporting it as an exception.console.debugwould be invisible noise and was also skipped.hasReverseProxyis theloadHasReverseProxySuccesslistener which marks an onboarding task complete ontrue. A swallowed failure simply leaves the task in its prior state, which is the desired behavior.Tools used: Read, Edit, Grep, Bash for repo inspection and
git_signed_commitfor the signed commit. No manual UI testing performed.Created with PostHog Code