fix(destinations): Update the digest email link to goto destinations, not sources#59694
Merged
Conversation
Contributor
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
posthog/templates/email/hog_functions_daily_digest.html:45-47
The button text still says "View Data Pipelines" but now points specifically to the destinations sub-page. Consider updating the label to match the destination so users know where they're headed.
```suggestion
<a class="button" href="{{ site_url }}/project/{{ team.id }}/pipeline/destinations">
View Destinations
</a>
```
Reviews (1): Last reviewed commit: "Keep the text though" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
dmarchuk
approved these changes
May 24, 2026
Contributor
dmarchuk
left a comment
dmarchuk
left a comment
There was a problem hiding this comment.
Thanks! 🙏 Looks good, I think it would make sense to apply the Greptile suggestion as well
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
kyleswank
force-pushed
the
kyle/destination-digest-email-link
branch
from
6465d88 to
dbc9fa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The link in the digest email for destinations sent the user to /pipelines which is the sources page, not the destinations page.
We shouldn't send users to the wrong page when they click a link.
Changes
How did you test this code?
Tested the URL manually, since that's all that changed
Publish to changelog?
Fixed link in destination daily digest email to goto destinations page, not sources page
Docs update
skip-inkeep-docs
🤖 Agent context