Skip to content

ci: use setup-sqlx-cli composite in 5 workflows#60098

Merged
rnegron merged 6 commits into
masterfrom
rauln/ci-sqlx-cli-composite
May 27, 2026
Merged

ci: use setup-sqlx-cli composite in 5 workflows#60098
rnegron merged 6 commits into
masterfrom
rauln/ci-sqlx-cli-composite

Conversation

@rnegron
Copy link
Copy Markdown
Member

@rnegron rnegron commented May 26, 2026

Problem

sqlx-cli is installed via a hand-copied cargo install line in 7 places across 5 CI workflows. A setup-sqlx-cli composite action already exists for exactly this and is used 4 times in ci-backend.yml; these callsites just never adopted it. Maintaining the install flags (version, features, --locked) in 7 spots is drift-prone.

Changes

Swap the 7 raw installs for uses: ./.github/actions/setup-sqlx-cli:

  • ci-agent-skills.yml (×2)
  • ci-mcp.yml
  • ci-e2e-playwright.yml
  • ci-ai.yml
  • cd-sandbox-base-image.yml

The composite builds the identical binary (0.8.0, --features postgres --no-default-features --locked) and adds an explicit version-keyed actions/cache with a cache-hit guard, so cold-cache jobs skip the build. No change to which jobs run or when.

Leaves ci-nodejs.yml untouched — it installs with --features native-tls,postgres, which the composite doesn't build. Covering it would need a features input on the composite (separate change).

How did you test this code?

I'm an agent. No manual testing. I validated that all 5 changed workflows parse as YAML (yaml.safe_load) and that the diff is a pure 1:1 swap with no other edits. CI's own actionlint and the affected workflow runs are the real verification.

Publish to changelog?

no

🤖 Agent context

Authored by Claude Code.

@rnegron rnegron marked this pull request as ready for review May 27, 2026 17:54
@rnegron rnegron added the stamphog Request AI review from stamphog label May 27, 2026
@assign-reviewers-posthog assign-reviewers-posthog Bot requested a review from a team May 27, 2026 17:55
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 27, 2026

Reviews (1): Last reviewed commit: "Merge branch 'master' into rauln/ci-sqlx..." | Re-trigger Greptile

Copy link
Copy Markdown

@stamphog stamphog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates denied this PR because it touches CI/CD workflows, which are on the deny-list. This requires human review regardless of the change's apparent simplicity.

@stamphog stamphog Bot removed the stamphog Request AI review from stamphog label May 27, 2026
@rnegron rnegron enabled auto-merge (squash) May 27, 2026 20:03
@rnegron rnegron merged commit b88c48f into master May 27, 2026
178 of 187 checks passed
@rnegron rnegron deleted the rauln/ci-sqlx-cli-composite branch May 27, 2026 20:34
@deployment-status-posthog
Copy link
Copy Markdown

deployment-status-posthog Bot commented May 27, 2026

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-05-27 21:03 UTC Run
prod-us ✅ Deployed 2026-05-27 21:21 UTC Run
prod-eu ✅ Deployed 2026-05-27 21:22 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants