ci: use setup-sqlx-cli composite in 5 workflows#60098
Merged
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "Merge branch 'master' into rauln/ci-sqlx..." | Re-trigger Greptile |
gantoine
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sqlx-cliis installed via a hand-copiedcargo installline in 7 places across 5 CI workflows. Asetup-sqlx-clicomposite action already exists for exactly this and is used 4 times inci-backend.yml; these callsites just never adopted it. Maintaining the install flags (version, features,--locked) in 7 spots is drift-prone.Changes
Swap the 7 raw installs for
uses: ./.github/actions/setup-sqlx-cli:ci-agent-skills.yml(×2)ci-mcp.ymlci-e2e-playwright.ymlci-ai.ymlcd-sandbox-base-image.ymlThe composite builds the identical binary (
0.8.0,--features postgres --no-default-features --locked) and adds an explicit version-keyedactions/cachewith a cache-hit guard, so cold-cache jobs skip the build. No change to which jobs run or when.Leaves
ci-nodejs.ymluntouched — it installs with--features native-tls,postgres, which the composite doesn't build. Covering it would need afeaturesinput on the composite (separate change).How did you test this code?
I'm an agent. No manual testing. I validated that all 5 changed workflows parse as YAML (
yaml.safe_load) and that the diff is a pure 1:1 swap with no other edits. CI's own actionlint and the affected workflow runs are the real verification.Publish to changelog?
no
🤖 Agent context
Authored by Claude Code.