chore: Explicitly disable multi-statements in Snowflake#60119
Merged
tomasfarias merged 1 commit intoMay 27, 2026
Merged
Conversation
1fc6875 to
afdacc9
Compare
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
products/batch_exports/backend/temporal/destinations/snowflake_batch_export.py:588-592
The session-parameters dict is defined inline here and as `_SNOWFLAKE_SESSION_PARAMETERS` in the destination-tests file — two places to update if the parameter set ever changes. Extracting a module-level constant here would follow the same pattern used in the test file and satisfy OnceAndOnlyOnce within this module.
```suggestion
# Pin Snowflake's per-session statement count to 1 to block
# multi-statement execution. This is already the connector default,
# but setting it explicitly means an account-level override cannot
# accidentally enable multi-statement execution.
session_parameters=_SNOWFLAKE_SESSION_PARAMETERS,
```
Reviews (1): Last reviewed commit: "chore: Explicitly disable multi-statemen..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multi-statements are disabled in Snowflake, but this is implicit.
Changes
Make it explicit by setting the approppiate session parameter.
How did you test this code?
Ran Snowflake tests. All passing.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Publish to changelog?
No
Docs update
No
🤖 Agent context
Used it to write it, then formatted the comment.