feat(capture): parallelize mutli-sink flush in graceful shutdown drain step#60173
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "add fanout for legacy + v1 event flush i..." | Re-trigger Greptile |
nickbest-ph
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Requested in prior PR review: instead of parallelizing only the v1 multi-sink
flush()during graceful shutdown, let's wrap the legacy flush call as well and fan them all out.Changes
As stated above. Tiny change
How did you test this code?
Locally and in CI (new tests not required for this)
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Publish to changelog?
N/A
Docs update
N/A
🤖 Agent context
Eli planned, Claude coded, Eli reviewed