fix(test): bump async timeout for TrendsLineChart tests#60225
Merged
Conversation
The default 1s waitFor / findBy timeout flakes on contended CI shards when mounting the full InsightViz tree under jsdom. Configure the testing-library async timeout to 5s at the file level instead of sprinkling per-call timeouts everywhere (mirrors the intent of #60177 on TrendsBarChart, but without the noise). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Reviews (1): Last reviewed commit: "fix(test): bump async timeout for Trends..." | Re-trigger Greptile |
Contributor
|
Size Change: 0 B Total Size: 80.2 MB ℹ️ View Unchanged
|
webjunkie
pushed a commit
that referenced
this pull request
May 27, 2026
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TrendsLineChartjest tests use the default 1swaitFor/findBy*timeout from testing-library. On contended CI shards (e.g.Jest test (EE - 1)), mounting the fullInsightViztree under jsdom occasionally takes longer than that, and tests flake withUnable to find role="img" and name "/chart with N data series/i". Seen on a recent unrelated PR run (#59109).#60177 fixed the equivalent issue on
TrendsBarChartby adding{ timeout: 5000 }to every individualwaitForandfindByRolecall. That works but it's noisy and easy to forget on new tests.Changes
configure({ asyncUtilTimeout: 5000 })at the top ofTrendsLineChart.test.tsx, which raises the default timeout for everywaitFor/findBy*in that file.How did you test this code?
I'm an agent. Ran the full test file locally — 48/48 pass (~17s). Did not run on CI from this branch yet.
Publish to changelog?
🤖 Generated with Claude Code