fix(data-table): keep "save as default" toggle visible in column configurator#60241
Merged
christiaan-ph merged 1 commit intoMay 27, 2026
Merged
Conversation
…igurator The column configurator modal nests an inner scrollable taxonomic filter inside the modal body. On smaller viewports the outer body also overflows, pushing the "Save as default for all project members" checkbox below the fold and behind the scroll, making it hard to discover. Move the checkbox into the modal footer alongside "Reset to defaults". The footer doesn't scroll, so the toggle is always visible regardless of viewport size. Drops the `bordered` style since the footer already provides separation, and wraps the left footer slot in `flex flex-wrap items-center gap-2` so it stacks gracefully on narrow screens. Generated-By: PostHog Code Task-Id: da222b0e-6f25-4a40-aa41-218953ea376b
Contributor
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
Contributor
|
Reviews (1): Last reviewed commit: "fix(data-table): keep "save as default" ..." | Re-trigger Greptile |
Contributor
|
Size Change: 0 B Total Size: 80.2 MB ℹ️ View Unchanged
|
christiaan-ph
deleted the
posthog-code/column-configurator-save-default-in-footer
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the data-table column configurator modal (Activity view and other tables that show "Configure columns"), the "Save as default for all project members" checkbox is hard to discover. The modal body contains an inner scrollable taxonomic filter (
h-[min(480px,60vh)]), and on shorter viewports the modal body itself also overflows — so the checkbox, which lived below the inner scroll area, gets pushed out of sight behind the outer scroll. Users have to scroll twice and in the right place to even know the option exists.Changes
Move the checkbox into the modal footer, next to "Reset to defaults". The footer doesn't scroll, so the toggle is always visible no matter the viewport size.
borderedstyle since the footer already provides visual separation.flex flex-wrap items-center gap-2so "Reset to defaults" + the checkbox stack gracefully on narrow screens instead of clipping.showPersistedColumnReorder && query.showPersistentColumnConfigurator), samedata-attr, same labels, samedisabledReasonhandling.How did you test this code?
I'm an agent. I made the structural edit and ran
pnpm --filter=@posthog/frontend typescript:check— no new errors in this file. The remaining errors in the run are from missingnode_modulesin the sandbox environment and are unrelated to this change. The PR author will test the modal on desktop and mobile viewports to confirm the toggle stays visible and the footer wraps cleanly.Christiaan tested this out locally, and it worked.
Publish to changelog?
no
🤖 Agent context
User flagged the discoverability problem in a support thread: the activity-view column configurator has a nested scroll (inner taxonomic filter + outer modal body), and the "Save as default for all project members" checkbox sits below the inner scroll inside the modal body. On smaller viewports the checkbox slides behind the outer scroll and is easy to miss.
Considered three options:
TaxonomicFiltervirtualizer needs a bounded height, so it would require larger refactoring.Chose option 1. The user confirmed they'll verify the mobile layout themselves.
Created with PostHog Code