feat(replay-vision): add overview per scanner#60264
Merged
Merged
Conversation
fasyy612
force-pushed
the
feat/add-scanner-oberview
branch
from
85d4dd3 to
aadd20f
Compare
Contributor
|
Size Change: +42.5 kB (+0.05%) Total Size: 80.3 MB 📦 View Changed
ℹ️ View Unchanged
|
assign-reviewers-posthog
Bot
requested review from
a team,
TueHaulund,
arnohillen,
ksvat and
nicowaltz
and removed request for
a team
Contributor
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
products/replay_vision/frontend/components/ObservationsDock.tsx:99
`seekToTime` called on wrong player instance
`sessionRecordingPlayerLogic` is keyed by `${playerKey}-${sessionRecordingId}` (see `sessionRecordingPlayerLogic.ts` line 474). Calling `useActions(sessionRecordingPlayerLogic)` here — without any props — will mount a *new* default instance (key `"undefined-undefined"`) that has no connection to the actual player rendering the recording. Clicking a citation chip in the dock will silently no-op. The `ReplayObservation.tsx` caller avoids this correctly by using `findMounted({ playerKey, sessionRecordingId })?.actions.seekToTime(ms)`; the same pattern is needed here.
### Issue 2 of 2
products/replay_vision/frontend/replay_scanners/components/ScannerOverview.tsx:148-164
`scaleMin` and `scaleMax` are declared in the props interface but never destructured or used inside the component body. They are passed by `ScorerOverview` but have no effect — superfluous per the simplicity rules. Either remove them from the type and the call site, or consume them to fix the box-plot's axis alignment against the configured scale.
```suggestion
function ScoreBoxPlot({
min,
p25,
median,
mean,
p75,
max,
}: {
min: number
p25: number
median: number
mean: number
p75: number
max: number
}): JSX.Element {
```
Reviews (1): Last reviewed commit: "use box chart for score distribution" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Overview components per scanner type would be useful for the users
Changes
How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Publish to changelog?
Docs update
🤖 Agent context