fix(hogli): trustworthy telemetry signals#60312
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Clean internal tooling fix by the owning team: consolidates CI detection into a shared is_ci() helper used consistently across telemetry gating and event properties, excludes telemetry management commands from tracking, and adds an outcome classifier for exit codes. Well-tested with no production-code impact.
Contributor
|
Reviews (1): Last reviewed commit: "Merge branch 'master' into worktree-hogl..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hogli telemetry is alive but noisy: the CI disable gate checks only
CIwhile theis_cilabel checks six providers (so CI runs leak in and inflate installs), barehogliemits acommand_completedwith no matchingcommand_started, thetelemetry:*commands track themselves, and a non-zeroexit_codecan't tell a real failure from a Ctrl-C.Changes
telemetry.is_ci()) shared by the gate and theis_cilabel. Depot CI runners setCI/GITHUB_ACTIONSso they're already covered;DEPOT_TOKENintentionally not gated (also on dev laptops)._should_track()(requires a subcommand, excludestelemetry:on/off/status) so they form matched pairs.outcomeproperty (success/error/interrupted) so signal kills read distinctly from failures.How did you test this code?
Agent-authored (Claude Code), automated tests only — no manual testing. 24 new tests; full hogli + hogli-commands suites pass (883). ruff and
tyclean.Publish to changelog?
no
🤖 Agent context
Authored by Claude Code; human author owns review/merge. Began as a check-in on whether the feature still produces useful data (queried the DevEx project via PostHog MCP, mapped the emit surface), which surfaced these fixes. CI logic kept in core
telemetry.pyper the framework boundary intools/hogli/CLAUDE.md. Scoped out:duration_sis ~0 for umbrella commands (needs sub-step timing) and ephemeral identity churn — both noted for follow-up.