chore(visual-review): document approve and tolerate MCP tools in skill#60417
Merged
Conversation
The triaging-visual-review-runs skill still said approval and toleration were not exposed as MCP tools, so the agent kept redirecting users to the web UI. The write tools landed; update the skill to use them. Generated-By: PostHog Code Task-Id: 31508ab9-fe78-49b1-a8b6-8c47d21cad54
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
Reviews (1): Last reviewed commit: "chore(visual-review): document approve a..." | Re-trigger Greptile |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90ce61a465
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
gantoine
approved these changes
May 28, 2026
The approval and toleration call-shape lists omitted the run `id` (the route parameter), and the toleration note said snapshot_id was used "not the run id" — which reads as if snapshot_id alone is the whole call. Both MCP tools require the run `id` in the path *and* their body fields, so an agent following the skill would hit a missing-route-parameter / validation failure. List `id` as required in both call shapes and clarify that snapshot_id selects which snapshot within the run rather than replacing the run id. Generated-By: PostHog Code Task-Id: 9c7e17df-cee3-4307-81cd-ffa8a4fcac6d
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While reviewing a VR run today, I followed the
triaging-visual-review-runsskill, gave a verdict on two diffs, and told the user they had to go approve in the web UI. The skill said: "Do not approve or tolerate snapshots from this skill — those endpoints are intentionally not exposed as MCP tools yet." The write tools have since landed (visual-review-runs-approve-create,visual-review-runs-tolerate-create), so that instruction is now misdirecting agents away from a perfectly good action.Changes
Update
products/visual_review/skills/triaging-visual-review-runs/SKILL.md:approve_allvs explicitsnapshots,new_hash=current_artifact.content_hash,commit_to_github,snapshot_id-not-run-id for tolerate).409 stale_runrecovery path — approving a stale run silently fails, and the fix is to list runs by PR number and pick the newest one. A successful approval usually triggers a fresh CI run, which is expected.How did you test this code?
Agent-authored. I'm an agent — no manual UI testing performed. Verified by:
posthog:exec search visual-reviewand confirming the two write tools are present.infoon bothvisual-review-runs-approve-createandvisual-review-runs-tolerate-createto confirm the input schemas match the call shapes I documented.409 stale_runpath live during the session that motivated this change — the recovery flow described in the skill is what I actually had to do.No automated tests touched; this is a markdown-only change to a skill file.
Publish to changelog?
no
Docs update
Not user-facing — internal agent skill only.
🤖 Agent context
Authored by PostHog Code (Claude Opus 4.7) in the session referenced via Task-Id in the commit trailer. Trigger: I noticed the stale instruction mid-session while triaging PR #60396's VR run. Paul confirmed in chat that the write tools had landed recently and asked me to update the skill.
No code logic changes — markdown edits to a single SKILL.md file. The plugin copy under `~/Library/Application Support/.../plugins/posthog/skills/...` will re-sync from this source on next plugin update.
Created with PostHog Code