Skip to content

chore(ci): replace changelog section with checklist in PR template#60479

Merged
joethreepwood merged 2 commits into
masterfrom
posthog-code/pr-template-checkboxes
May 28, 2026
Merged

chore(ci): replace changelog section with checklist in PR template#60479
joethreepwood merged 2 commits into
masterfrom
posthog-code/pr-template-checkboxes

Conversation

@joethreepwood
Copy link
Copy Markdown
Contributor

Problem

The PR template's freeform "Publish to changelog?" section was easy to overlook, and there was no equivalent prompt to notify Sales and Marketing about user-visible changes.

Changes

  • Removed the freeform ## Publish to changelog? section from .github/pull_request_template.md.
  • Added a ## Checklist section with two checkboxes:
    • Publish to changelog?
    • Alert Sales and Marketing teams?

How did you test this code?

I'm an agent — no manual testing was performed. The change is a pure markdown edit to the PR template; rendering will be verified by GitHub when this PR opens.

Checklist

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Docs update

No docs update required — this is a CI/repo-hygiene change.

🤖 Agent context

Authored by an agent on request: convert the freeform changelog section into two explicit checkboxes (changelog publish + Sales/Marketing alert). Considered keeping the explanatory HTML comments from the old section but opted to drop them so the new checklist stays terse; the same intent can be re-added later if reviewers find the prompts ambiguous. No other template sections were touched.


Created with PostHog Code

Replaces the freeform "Publish to changelog?" section with a checklist containing two checkboxes: "Publish to changelog?" and "Alert Sales and Marketing teams?".

Generated-By: PostHog Code
Task-Id: 7cc1291b-7087-4be5-99f8-aa3bf8aa555c
@joethreepwood joethreepwood requested a review from edwinyjlim May 28, 2026 16:44
Comment thread .github/pull_request_template.md Outdated
Copy link
Copy Markdown
Contributor

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good :D

@joethreepwood joethreepwood marked this pull request as ready for review May 28, 2026 16:55
@joethreepwood joethreepwood merged commit cc860c8 into master May 28, 2026
142 checks passed
@joethreepwood joethreepwood deleted the posthog-code/pr-template-checkboxes branch May 28, 2026 16:55
@assign-reviewers-posthog assign-reviewers-posthog Bot requested a review from a team May 28, 2026 16:55
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 28, 2026

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
.github/pull_request_template.md:29
The heading `## Automatic notifications` is slightly misleading — these are manual checkboxes prompting the author to take action, not automated processes. The PR description itself calls this section a "Checklist", which is clearer and aligns better with what the items actually represent.

```suggestion
## Checklist
```

Reviews (1): Last reviewed commit: "Apply suggestion from @joethreepwood" | Re-trigger Greptile

👉 _Stay up-to-date with [PostHog coding conventions](https://posthog.com/docs/contribute/coding-conventions) for a smoother review._

## Publish to changelog?
## Automatic notifications
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The heading ## Automatic notifications is slightly misleading — these are manual checkboxes prompting the author to take action, not automated processes. The PR description itself calls this section a "Checklist", which is clearer and aligns better with what the items actually represent.

Suggested change
## Automatic notifications
## Checklist
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/pull_request_template.md
Line: 29

Comment:
The heading `## Automatic notifications` is slightly misleading — these are manual checkboxes prompting the author to take action, not automated processes. The PR description itself calls this section a "Checklist", which is clearer and aligns better with what the items actually represent.

```suggestion
## Checklist
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@deployment-status-posthog
Copy link
Copy Markdown

deployment-status-posthog Bot commented May 28, 2026

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-05-28 17:28 UTC Run
prod-us ✅ Deployed 2026-05-28 17:52 UTC Run
prod-eu ✅ Deployed 2026-05-28 17:56 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants