Skip to content

fix(sources): Convex is using regions in their deployment urls, lets support those#60504

Merged
Gilbert09 merged 1 commit into
masterfrom
kyle/update-convex-url-test
May 29, 2026
Merged

fix(sources): Convex is using regions in their deployment urls, lets support those#60504
Gilbert09 merged 1 commit into
masterfrom
kyle/update-convex-url-test

Conversation

@kyleswank
Copy link
Copy Markdown
Contributor

Problem

Seems that convex is using regions in their deployment urls, our current regex check fails valid urls.

Changes

  • Added an optional region subdomain check to the regex
  • Added tests

How did you test this code?

  • Created tests

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Docs update

🤖 Agent context

@kyleswank kyleswank self-assigned this May 28, 2026
@kyleswank kyleswank added skip-inkeep-docs Use this label to skip an Inkeep docs PR in posthog.com skip-migration-service-check Author attests every migration in this PR is DB-noop and safe to ship alongside service code labels May 28, 2026
@kyleswank kyleswank removed their assignment May 28, 2026
@assign-reviewers-posthog assign-reviewers-posthog Bot requested a review from a team May 28, 2026 17:54
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 28, 2026

Reviews (1): Last reviewed commit: "Convex is using regions in their deploym..." | Re-trigger Greptile

@kyleswank kyleswank removed the skip-inkeep-docs Use this label to skip an Inkeep docs PR in posthog.com label May 28, 2026
Copy link
Copy Markdown
Contributor

@danielcarletti danielcarletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gilbert09 Gilbert09 merged commit 0180bba into master May 29, 2026
253 of 265 checks passed
@Gilbert09 Gilbert09 deleted the kyle/update-convex-url-test branch May 29, 2026 10:00
@deployment-status-posthog
Copy link
Copy Markdown

deployment-status-posthog Bot commented May 29, 2026

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-05-29 10:23 UTC Run
prod-us ✅ Deployed 2026-05-29 10:35 UTC Run
prod-eu ✅ Deployed 2026-05-29 10:39 UTC Run

mayteio pushed a commit that referenced this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-migration-service-check Author attests every migration in this PR is DB-noop and safe to ship alongside service code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants