chore(workflows): revert distinct_id description on update person properties#60647
Merged
meikelmosby merged 1 commit intoMay 29, 2026
Merged
Conversation
…perties
Revert the description back to "The distinct ID associated with the Person." now that batch-trigger workflows can use `{event.distinct_id}` directly. The previous wording suggesting `{person.id}` for batch workflows is no longer accurate.
Generated-By: PostHog Code
Task-Id: 63f5eb2b-31eb-4c91-88d1-0cd14338a5b6
dmarchuk
approved these changes
May 29, 2026
Contributor
|
Reviews (1): Last reviewed commit: "chore(workflows): revert distinct_id des..." | Re-trigger Greptile |
meikelmosby
deleted the
posthog-code/revert-update-person-properties-description
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Update person propertiesworkflow action'sdistinct_idinput description was changed in #58831 to suggest using{person.id}for batch-triggered workflows. That guidance is incorrect —{person.id}is the person UUID, which does not match an existingdistinct_idand ends up creating a new person profile on capture.Now that batch-trigger workflows populate
{event.distinct_id}directly, the older, simpler description is accurate again.Changes
Revert the
distinct_idinput description ontemplate-posthog-update-person-propertiesback to:How did you test this code?
Agent-authored change. No tests were run — this is a single string-literal revert in a template file. The default value (
{event.distinct_id}) and surrounding schema are unchanged.Automatic notifications
Docs update
No docs changes.
🤖 Agent context
Authored by PostHog Code at a user's request after a support thread surfaced that batch-trigger workflows now provide
{event.distinct_id}correctly, so the prior advice to use{person.id}for batch workflows is no longer accurate (and was actively misleading — it minted new person profiles). The user asked to revert the description to its pre-#58831 wording. The previous wording was retrieved from the GitHub commit history (commit2e82feb3) since the local checkout only contained a single commit.Created with PostHog Code