fix(signals): default inbox deep link to posthog-code scheme#60649
Merged
Conversation
Flip the default deep link scheme for the Slack inbox notification button from `posthog-code-dev` to `posthog-code` so links open the production desktop app. Dev environments can still override via `POSTHOG_CODE_INBOX_DEEP_LINK_SCHEME`. Generated-By: PostHog Code Task-Id: 5d4c7fbe-69c3-4358-8175-8aaea71f241d
Contributor
|
Reviews (1): Last reviewed commit: "fix(signals): default inbox deep link to..." | Re-trigger Greptile |
sortafreel
approved these changes
May 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Slack “Open in PostHog Code” inbox notification deep link to default to the production PostHog Code desktop app scheme, while keeping the scheme configurable via Django settings for dev/overrides.
Changes:
- Change the default
POSTHOG_CODE_INBOX_DEEP_LINK_SCHEMEfromposthog-code-devtoposthog-code. - Update Slack notification tests to assert the new default deep link URL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| products/signals/backend/slack_inbox_notifications.py | Switches default deep link scheme used to build the Slack button URL to the production scheme. |
| products/signals/backend/test/test_slack_inbox_notifications.py | Updates assertions to match the new default deep link URL scheme. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Slack inbox notification "Open in PostHog Code" button was generating
posthog-code-dev://links by default, which only open the dev build of the PostHog Code desktop app. End users with the production app installed couldn't follow the deep link.Changes
POSTHOG_CODE_INBOX_DEEP_LINK_SCHEMEfromposthog-code-devtoposthog-codeso deep links target the production desktop app out of the box.POSTHOG_CODE_INBOX_DEEP_LINK_SCHEME=posthog-code-devvia env/settings.How did you test this code?
I'm an agent. I updated the two existing tests in
products/signals/backend/test/test_slack_inbox_notifications.pyto assert the new default scheme. I did not run the test suite or manually verify the Slack rendering.Automatic notifications
Docs update
No docs reference this deep link scheme.
🤖 Agent context
PostHog Code session. Searched for
posthog-code-devreferences — found one default inslack_inbox_notifications.pyplus two test assertions. The constant is already designed to be env-overridable, so the fix is just flipping the default; dev users who want the dev-app deep link can still setPOSTHOG_CODE_INBOX_DEEP_LINK_SCHEMEexplicitly.Created with PostHog Code