fix(signals): always allow local domains#60656
Merged
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "always allow local domains" | Re-trigger Greptile |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the AgentSH network policy generation used by the tasks/signals sandboxing pipeline so local development in Docker sandboxes can reach local/host services without being blocked by the domain allowlist.
Changes:
- Adds a dedicated debug-only network rule (
allow-local-dev-hosts) to allowlocalhostandhost.docker.internalon any port. - Removes adding local dev hostnames into the “infrastructure domains” list, keeping that list focused on actual infrastructure.
- Adds tests asserting the debug-only rule exists, has no port restriction, and appears before the default deny rule.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| products/tasks/backend/services/agentsh.py | Adds a DEBUG-only allow rule for local dev hostnames and refactors where local domains are injected into policy generation. |
| products/tasks/backend/tests/test_agentsh.py | Adds test coverage to ensure debug-mode local host rules exist, are unrestricted by port, and have correct precedence. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrewm4894
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signals pipeline breaks locally with docker sandboxes due to local domains not being allowlisted for all ports, we don't mind which ports they use locally and we want to allow it to access the MCP server at 8787