Skip to content

fix(signals): always allow local domains#60656

Merged
joshsny merged 1 commit into
masterfrom
signals/allow-local-domains
May 29, 2026
Merged

fix(signals): always allow local domains#60656
joshsny merged 1 commit into
masterfrom
signals/allow-local-domains

Conversation

@joshsny
Copy link
Copy Markdown
Contributor

@joshsny joshsny commented May 29, 2026

Signals pipeline breaks locally with docker sandboxes due to local domains not being allowlisted for all ports, we don't mind which ports they use locally and we want to allow it to access the MCP server at 8787

Copilot AI review requested due to automatic review settings May 29, 2026 11:36
@assign-reviewers-posthog assign-reviewers-posthog Bot requested a review from a team May 29, 2026 11:37
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 29, 2026

Reviews (1): Last reviewed commit: "always allow local domains" | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the AgentSH network policy generation used by the tasks/signals sandboxing pipeline so local development in Docker sandboxes can reach local/host services without being blocked by the domain allowlist.

Changes:

  • Adds a dedicated debug-only network rule (allow-local-dev-hosts) to allow localhost and host.docker.internal on any port.
  • Removes adding local dev hostnames into the “infrastructure domains” list, keeping that list focused on actual infrastructure.
  • Adds tests asserting the debug-only rule exists, has no port restriction, and appears before the default deny rule.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
products/tasks/backend/services/agentsh.py Adds a DEBUG-only allow rule for local dev hostnames and refactors where local domains are injected into policy generation.
products/tasks/backend/tests/test_agentsh.py Adds test coverage to ensure debug-mode local host rules exist, are unrestricted by port, and have correct precedence.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread products/tasks/backend/services/agentsh.py
@joshsny joshsny requested review from a team and removed request for a team May 29, 2026 11:41
@joshsny joshsny enabled auto-merge (squash) May 29, 2026 11:49
@joshsny joshsny merged commit 83fefcc into master May 29, 2026
210 checks passed
@joshsny joshsny deleted the signals/allow-local-domains branch May 29, 2026 11:57
@deployment-status-posthog
Copy link
Copy Markdown

deployment-status-posthog Bot commented May 29, 2026

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-05-29 12:26 UTC Run
prod-us ✅ Deployed 2026-05-29 13:01 UTC Run
prod-eu ✅ Deployed 2026-05-29 12:54 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants