feat(llma): Extract title to show on sessions page#60667
Merged
Conversation
mp-hog
changed the title
mp-hog
added
the
skip-inkeep-docs
Contributor
|
Size Change: +2.9 kB (0%) Total Size: 80.8 MB 📦 View Changed
ℹ️ View Unchanged
|
mp-hog
changed the title
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
products/ai_observability/frontend/sessionTitle.test.ts:142-213
**Prefer parameterised tests for related truncation and content cases**
The project convention is to use `it.each` when testing variants of the same behaviour. Three tests here exercise the same `truncate` path with different inputs (long input, short input, custom `maxLength`), and two others exercise content extraction (`array-shaped content`, `skips empty content`). Collapsing each group into an `it.each` table would shrink the noise and make it easier to add new cases later without copy-pasting setup.
Reviews (1): Last reviewed commit: "Merge branch 'master' into llma/extract-..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Radu-Raicea
reviewed
May 29, 2026
| : inputPayload | ||
| const normalized = normalizeMessages(messages, '') | ||
| for (const message of normalized) { | ||
| if (message.role !== 'user') { |
Member
There was a problem hiding this comment.
What if we have something like $ai_input being just a string? If the default role is '', it won't catch this.
Radu-Raicea
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sessions on the overview page currently are shown by ID and give no clue about the content. Since traces/sessions are very versatile, this PR introduces showing the title on the details page as a first step.
Changes
Show title on sessions page:
How did you test this code?
(But as mentioned, only shown on sessions details page for now nevertheless and not the table yet)