Skip to content

fix(ci): exempt github noreply emails from the author-email nudge#60693

Merged
webjunkie merged 1 commit into
masterfrom
claude/dazzling-wright-5toTI
May 29, 2026
Merged

fix(ci): exempt github noreply emails from the author-email nudge#60693
webjunkie merged 1 commit into
masterfrom
claude/dazzling-wright-5toTI

Conversation

@webjunkie
Copy link
Copy Markdown
Contributor

Problem

The check-author-email nudge (added in #60613) comments on a PR when an org member's commits use a non-@posthog.com git author email. As written, it also fires for GitHub privacy addresses like 80100530+darkopia@users.noreply.github.com, which real PostHog members legitimately use.

These are a different situation from an accidental someone@gmail.com:

  • The commit is already attributable to a real GitHub account (the numeric ID encodes the user), so org membership still maps it to a person — the "who wrote this?" problem is already solved.
  • Using the noreply address is a deliberate "keep my email private" choice on a public repo. Nudging someone to swap it for you@posthog.com is asking them to publish their work email — reversing an intentional choice, not fixing a misconfiguration.

Changes

Skip author emails ending in @users.noreply.github.com before the @posthog.com check, so they no longer trigger the nudge. Personal/unattributed emails are still caught.

How did you test this code?

I'm an agent. No automated test suite covers this workflow's inline script. I validated the file with actionlint (passes), confirmed it's oxfmt-clean, and checked the YAML parses. The logic change is a single early-continue in the email loop, reasoned through the GitHub noreply-attribution behavior described above.

🤖 Agent context

Authored by Claude Code (Opus) at the request of @webjunkie as a follow-up to #60613.

Decision trail:

  • Considered three options — exempt noreply, keep nudging but reword to acknowledge the privacy tradeoff, or leave as-is.
  • The deciding factor: noreply addresses are already attributable to a real GitHub identity (unlike a random personal email, which only links if registered to the account), and they represent a deliberate privacy choice on a public repo. The nudge's value is highest for accidental/unattributed emails and arguably negative for noreply.
  • Rejected "keep nudging, reword" because it would still nag people who made an intentional choice; it would only be warranted if internal contribution tooling matched on email domain rather than GitHub login.
  • Chose to exempt, matching the maintainers' stated preference for keeping this low-noise.

Generated by Claude Code

Copilot AI review requested due to automatic review settings May 29, 2026 15:21
@assign-reviewers-posthog assign-reviewers-posthog Bot requested a review from a team May 29, 2026 15:22
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 29, 2026

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
.github/workflows/pr-opened.yml:150
The log message says "All author commits use a `@posthog.com` email" but that's no longer accurate — commits with noreply addresses also skip the nudge without using a `@posthog.com` email. When debugging a run where all commits used noreply addresses, this message would be misleading.

```suggestion
                          console.log('No offending emails found (all commits use a @posthog.com or noreply address) — nothing to nudge.');
```

Reviews (1): Last reviewed commit: "fix(ci): exempt github noreply emails fr..." | Re-trigger Greptile

Comment thread .github/workflows/pr-opened.yml
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the PR-opened GitHub Actions workflow’s “author email nudge” logic so that GitHub privacy/noreply addresses (*@users.noreply.github.com) don’t trigger the non-@posthog.com reminder for PostHog org members.

Changes:

  • Adds/updates the check-author-email job that checks PR commits authored by the PR author for non-@posthog.com emails.
  • Exempts @users.noreply.github.com addresses from being considered “offending” emails.
  • Posts a single deduped nudge comment on the PR when offending emails are found.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pr-opened.yml
@webjunkie webjunkie force-pushed the claude/dazzling-wright-5toTI branch from 8dc7762 to 4f99aaf Compare May 29, 2026 15:24
@webjunkie webjunkie added the stamphog Request AI review from stamphog label May 29, 2026
@webjunkie webjunkie enabled auto-merge (squash) May 29, 2026 15:26
Copy link
Copy Markdown

@stamphog stamphog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR modifies a GitHub Actions workflow file, which is blocked by the CI/CD deny-list gate. Changes to .github/workflows/ require human review regardless of how small the change is.

@stamphog stamphog Bot removed the stamphog Request AI review from stamphog label May 29, 2026
@webjunkie webjunkie merged commit 2f497cd into master May 29, 2026
176 checks passed
@webjunkie webjunkie deleted the claude/dazzling-wright-5toTI branch May 29, 2026 16:45
@gantoine
Copy link
Copy Markdown
Member

This PR modifies a GitHub Actions workflow file, which is blocked by the CI/CD deny-list gate

this is a good thing!

@deployment-status-posthog
Copy link
Copy Markdown

deployment-status-posthog Bot commented May 29, 2026

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-05-29 17:21 UTC Run
prod-us ✅ Deployed 2026-05-29 17:44 UTC Run
prod-eu ✅ Deployed 2026-05-29 17:46 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants