fix(ci): exempt github noreply emails from the author-email nudge#60693
Merged
Conversation
2 tasks
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
.github/workflows/pr-opened.yml:150
The log message says "All author commits use a `@posthog.com` email" but that's no longer accurate — commits with noreply addresses also skip the nudge without using a `@posthog.com` email. When debugging a run where all commits used noreply addresses, this message would be misleading.
```suggestion
console.log('No offending emails found (all commits use a @posthog.com or noreply address) — nothing to nudge.');
```
Reviews (1): Last reviewed commit: "fix(ci): exempt github noreply emails fr..." | Re-trigger Greptile |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the PR-opened GitHub Actions workflow’s “author email nudge” logic so that GitHub privacy/noreply addresses (*@users.noreply.github.com) don’t trigger the non-@posthog.com reminder for PostHog org members.
Changes:
- Adds/updates the
check-author-emailjob that checks PR commits authored by the PR author for non-@posthog.comemails. - Exempts
@users.noreply.github.comaddresses from being considered “offending” emails. - Posts a single deduped nudge comment on the PR when offending emails are found.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8dc7762 to
4f99aaf
Compare
gantoine
approved these changes
May 29, 2026
Member
this is a good thing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
check-author-emailnudge (added in #60613) comments on a PR when an org member's commits use a non-@posthog.comgit author email. As written, it also fires for GitHub privacy addresses like80100530+darkopia@users.noreply.github.com, which real PostHog members legitimately use.These are a different situation from an accidental
someone@gmail.com:you@posthog.comis asking them to publish their work email — reversing an intentional choice, not fixing a misconfiguration.Changes
Skip author emails ending in
@users.noreply.github.combefore the@posthog.comcheck, so they no longer trigger the nudge. Personal/unattributed emails are still caught.How did you test this code?
I'm an agent. No automated test suite covers this workflow's inline script. I validated the file with
actionlint(passes), confirmed it'soxfmt-clean, and checked the YAML parses. The logic change is a single early-continuein the email loop, reasoned through the GitHub noreply-attribution behavior described above.🤖 Agent context
Authored by Claude Code (Opus) at the request of @webjunkie as a follow-up to #60613.
Decision trail:
Generated by Claude Code