refactor(customer-analytics): remove REST endpoint tab from accounts#60717
Merged
Conversation
Contributor
|
Size Change: -7.81 kB (-0.01%) Total Size: 80.8 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
|
✅ Visual changes approved by @arthurdedeus — baseline updated in 10 changed. |
2 tasks
arthurdedeus
force-pushed
the
posthog-code/accounts-name-tuple-refactor
branch
from
83c025d to
0ab32f1
Compare
Base automatically changed from
posthog-code/accounts-name-tuple-refactor
to
master
May 29, 2026 21:20
Backend API is preserved; the UI now renders the HogQL table directly. Role updates fetch the current account before patching to keep merged properties intact. Generated-By: PostHog Code Task-Id: 3f8b5bcc-1e21-4127-9113-32a0f65353c1
10 updated Run: 408bc974-76b7-4290-8689-df0c9cae382f Co-authored-by: arthurdedeus <54866778+arthurdedeus@users.noreply.github.com>
arthurdedeus
force-pushed
the
posthog-code/remove-accounts-rest-tab
branch
from
6647299 to
8028db9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
No need to keep both, as the HogQL is capable of doing the same and more.
Changes
REST endpointtab and related componentsHow did you test this code?
Unit tests, refactored snapshot tests to assert the HogQL version and manual tests in the UI.
Automatic notifications
Docs update
🤖 Agent context
Authored by PostHog Code (Claude Opus 4.7). Considered two designs for keeping the role update flow correct without the REST loader:
propertiesobject through from the HogQL row. Rejected because the HogQL select only includes the visible columns, so non-displayed properties (stripe_customer_id, etc.) would be silently wiped on PATCH.accountsRetrievethen PATCH the merged properties. Chosen — costs one extra GET per role change but keeps the merge correct against any future property additions without coupling the UI to the column selection.Dropped optimistic UI updates with that change; the saving spinner on the role cell covers the in-flight window.
accountOverridesis still used to reflect the PATCH response so the cell updates without waiting for the HogQL refetch to come back.Decided not to delete
AccountsTab.stories.tsxeven though it was originally REST-mock-driven — the user pushed back on dropping it. Rewrote the mocks to dispatch onquery.kindso the HogQL table renders against deterministic rows.Created with PostHog Code