refactor(max): move homepage hands-free start into a logic listener#60783
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
Reviews (1): Last reviewed commit: "refactor(max): move homepage hands-free ..." | Re-trigger Greptile |
Contributor
|
Size Change: 0 B Total Size: 80.8 MB ℹ️ View Unchanged
|
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
Member
Author
|
Note 🤖 Automated comment by QA Swarm — not written by a human Multi-perspective review: qa-team (specialists + generalists), paul-reviewer, xp-reviewer, security-audit Verdict: 💬 APPROVE WITH NITSClean, low-risk refactor — the mic button's inline Convergence (highest confidence)
Nits (non-blocking, not addressed in this PR)
Reviewer summaries
Automated by QA Swarm — not a human review |
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
Contributor
|
✅ Visual changes approved by @pauldambra — baseline updated in 2 changed. |
The homepage idle mic button fired four calls inline in its onClick
handler: capture, startNewConversation, submitQuery('ai'), enterHandsFree.
That is business logic living in a React handler.
Give aiFirstHomepageLogic a startHandsFreeChat action whose listener owns
the sequence, and connect handsFreeLogic's enterHandsFree so the whole flow
lives in one place. The ordering the original relied on is preserved
(synchronous action calls in the same order). The button is now just
onClick={startHandsFreeChat}; the handsFreeAvailable render gate stays in
the component.
Generated-By: PostHog Code
Task-Id: 24894780-dfaf-4242-9ceb-db6893f4ec40
The comment claimed startNewConversation made submitQuery's create-on-demand branch skip, but startNewConversation nulls conversationId via a reducer, so the branch is actually taken (a harmless second startNewConversation). Reword to state the real intent: clear any in-progress conversation so hands-free always starts a fresh thread. Generated-By: PostHog Code Task-Id: 24894780-dfaf-4242-9ceb-db6893f4ec40
pauldambra
force-pushed
the
posthog-code/homepage-hands-free-listener
branch
from
402074e to
6ed348d
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The homepage idle-input mic button (added in #60122) fired four calls inline in its
onClickhandler:posthog.capture,startNewConversation(),submitQuery('ai'), andenterHandsFree(). That is business logic living in a React handler, which our frontend convention asks us to keep in the kea logic instead.Changes
startHandsFreeChataction toaiFirstHomepageLogicwhose listener owns the full sequence, andconnecthandsFreeLogic'senterHandsFreeso the flow lives in one place.onClick={startHandsFreeChat}.handsFreeAvailablerender gate stays in the component (a render concern).No behaviour change — the listener makes the same synchronous action calls in the same order the click handler did, so the ordering the original relied on (fresh conversation before AI-mode transition before Scribe starts) is preserved.
How did you test this code?
I'm an agent. I regenerated kea typegen (
pnpm typegen:write, exit 0 with--show-ts-errors) and confirmedaiFirstHomepageLogicType.tsnow carries bothstartHandsFreeChatand the connectedenterHandsFree. No automated test covers this interaction directly; I did not perform manual browser testing.🤖 Agent context
Authored with PostHog Code. This is a small follow-up refactor to #60122 (which merged before the change landed): it relocates the mic button's inline
onClicksequence into a singlestartHandsFreeChatlistener onaiFirstHomepageLogic. Considered keeping it in the handler vs. moving to the logic; moved it to honour the "business logic in kea, not React handlers" convention. Ordering betweenstartNewConversation/submitQuery('ai')/enterHandsFreewas preserved deliberately and documented in a code comment.Created with PostHog Code