Skip to content

fix(ci): deploy cymbal resolution image#60877

Merged
hpouillot merged 1 commit into
masterfrom
hp/cymbal-resolution-deploy-matrix
Jun 1, 2026
Merged

fix(ci): deploy cymbal resolution image#60877
hpouillot merged 1 commit into
masterfrom
hp/cymbal-resolution-deploy-matrix

Conversation

@hpouillot
Copy link
Copy Markdown
Contributor

Problem

The cymbal-resolution Rust image is built, but it is not included in the deploy matrix that dispatches chart state updates. As a result, new image digests are not written to charts state and deployments can render without a valid image digest.

Changes

  • Add cymbal-resolution to the Rust image deploy matrix.
  • Map the release name and digest key to cymbal-resolution so the charts repo receives commit_state_update for the matching state entry.

How did you test this code?

As an agent, I validated that the workflow YAML parses with:

yq e '.' .github/workflows/rust-docker-build.yml

Commit hooks also ran successfully.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Docs update

No docs update needed; this is a CI deploy-matrix fix.

🤖 Agent context

This PR was authored with pi using shell, file-read, and edit tools. The change follows the existing Rust image deployment pattern: the image already exists in .github/rust-images.yml, and this adds the corresponding deploy-matrix entry so charts state updates use the same cymbal-resolution key.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

Hey @hpouillot! 👋

It looks like your git author email on this PR isn't your @posthog.com address (hpouillot@gmail.com). Since you're on the PostHog team, it's worth pointing your local git author email at your @posthog.com address. Why it matters:

  • Consistent work identity in git history — internal tooling that attributes commits to team members keys off your @posthog.com address.
  • Keeps team contributions easy to tell apart from external community ones when scanning history.

You can fix it for this repo with:

git config user.email "you@posthog.com"

Or set it globally with git config --global user.email "you@posthog.com". No need to redo this PR — just a nudge for next time. 🙂

@assign-reviewers-posthog assign-reviewers-posthog Bot requested a review from a team June 1, 2026 11:43
@hpouillot hpouillot added the stamphog Request AI review from stamphog label Jun 1, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 1, 2026

Reviews (1): Last reviewed commit: "fix(ci): deploy cymbal resolution image" | Re-trigger Greptile

Copy link
Copy Markdown

@stamphog stamphog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates denied this PR because it modifies a CI/CD workflow file, which is on the infrastructure/CI deny-list and requires human review from @PostHog/team-devex.

@stamphog stamphog Bot removed the stamphog Request AI review from stamphog label Jun 1, 2026
@hpouillot hpouillot requested review from a team, ablaszkiewicz and cat-ph June 1, 2026 12:01
@hpouillot hpouillot merged commit a46d50b into master Jun 1, 2026
207 of 208 checks passed
@hpouillot hpouillot deleted the hp/cymbal-resolution-deploy-matrix branch June 1, 2026 12:02
@deployment-status-posthog
Copy link
Copy Markdown

deployment-status-posthog Bot commented Jun 1, 2026

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-06-01 12:38 UTC Run
prod-us ✅ Deployed 2026-06-01 12:52 UTC Run
prod-eu ✅ Deployed 2026-06-01 12:55 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants