feat(taxonomic-filter): verified badges, telemetry, and cohort search fix#60889
Merged
Conversation
Surface verification status in the rebuilt taxonomic filter menu. Core PostHog definitions (isCoreFilter) get a "PostHog" badge; team-verified custom definitions get a "Verified" badge. Rendered both inline in the combobox rows (left of the selected check) and in the preview pane, each with a tooltip explaining the status. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Reviews (1): Last reviewed commit: "feat(taxonomic-filter): add verified/Pos..." | Re-trigger Greptile |
Contributor
|
Size Change: +8.38 kB (+0.01%) Total Size: 80.9 MB 📦 View Changed
ℹ️ View Unchanged
|
Fill gaps in the rebuilt menu's instrumentation: - option clicks (New/Recent/Pinned/DWH/HogQL) via a new "taxonomic filter menu option clicked" event - category switches via "taxonomic filter menu category changed" (via=tab|dropdown) so Tab-cycling and the dropdown are both captured - pin/unpin via "taxonomic filter menu pin toggled" - time-to-select (msSinceOpen) on item selection - quick-reopen funnel (msSinceLastClose / reopenedQuickly) on open All additive — existing event/property shapes are unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
Endpoint-backed groups (e.g. Cohorts) are already searched server-side — the endpoint is the search authority, including server-side behavioral-cohort exclusion. The menu combobox was running its own Fuse pass on top of those server results, filtering them a second, fuzzier time. Fuse scoring isn't monotonic as the query grows against a changing candidate set, so a valid match shown for "posthog te" could vanish at "posthog team". Only Fuse locally-sourced groups (Actions etc., which load their full list client-side); pass server-searched entries through untouched in their existing order. Behavioral-cohort exclusion stays server-side where it must (it depends on server feature-flag config + cohort dependency resolution that can't be reproduced on the client). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
adamleithp
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three related improvements to the rebuilt taxonomic filter menu:
Changes
Verified / PostHog badges
menu/VerificationBadge.tsx. Core PostHog definitions (isCoreFilter) get a PostHog badge; team-verified definitions (item.verified) get a Verified badge. Mutually exclusive, mirroringDefinitionPopover'sallowVerification.Telemetry coverage
taxonomic filter menu option clicked(New / Recent / Pinned / DWH / HogQL)taxonomic filter menu category changed(via: tab | dropdown) — covers both Tab-cycling and the category dropdowntaxonomic filter menu pin toggledmsSinceOpen(time-to-select) on item selectionmsSinceLastClose/reopenedQuicklyon open (quick-reopen funnel)Cohort search fix
name__icontainsplus server-side behavioral-cohort exclusion). Fuse scoring isn't monotonic as the candidate set shifts per keystroke, so a valid server match could drop out as the query grew.How did you test this code?
I'm an agent (Claude Code). Automated checks run locally:
pnpm --filter=@posthog/frontend typescript:check— clean on touched filespnpm --filter=@posthog/frontend format— cleanManual verification by the human author against the live app: badges + tooltips render in rows and preview pane; the cohort search regression ("posthog team" disappearing) is resolved. I did not run the full visual-regression suite.
🤖 Agent context
Authored with Claude Code (Opus 4.8).
Notable decisions:
Badgeis a plain function component (notforwardRef), so passing it directly as aTooltipTrigger render={<Badge/>}dropped base-ui's ref and the tooltip never anchored. Fixed by rendering the trigger as a host<span>with the Badge as content.Reviewer note: the PostHog badge shows on every core
$-prefixed definition, so high-traffic categories (events, properties) display many badges. That matches the requested behavior; flag if it reads as too noisy.