chore: use ReleaseStatus enum for warehouse source release status#60893
Conversation
Update the implementing-warehouse-sources skill so new sources set releaseStatus via the ReleaseStatus enum (ALPHA/BETA/GA) imported from posthog.schema rather than bare string literals. Generated-By: PostHog Code Task-Id: 59df82d8-15e8-4a33-b091-d7e5182d4f5c
|
Hey @Gilbert09! 👋 It looks like your git author email on this PR isn't your
You can fix it for this repo with: git config user.email "you@posthog.com"Or set it globally with |
|
Reviews (1): Last reviewed commit: "chore: use ReleaseStatus enum for wareho..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
Updates the implementing-warehouse-sources agent skill documentation to align warehouse source releaseStatus guidance with the codebase’s preferred ReleaseStatus enum usage (instead of string literals), reducing drift between docs and current source implementations.
Changes:
- Update Step 13 (“Release status”) to recommend using
ReleaseStatusenum members (ALPHA/BETA/GA) rather than"alpha"/"beta"/"ga". - Update the “Release status” checklist to reference enum usage and add an explicit “never a string literal” reminder.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix an invalid Python import example (`...` placeholder) and reword the guidance so it no longer implies releaseStatus must always be set — "when set, use the enum" — keeping it consistent with leaving releaseStatus unset for GA. Generated-By: PostHog Code Task-Id: 59df82d8-15e8-4a33-b091-d7e5182d4f5c
Problem
The
implementing-warehouse-sourcesskill documented settingreleaseStatuswith bare string literals ("alpha","beta","ga"). Newer sources (e.g.resend,plain,revenuecat,customer_io) already use theReleaseStatusenum fromposthog.schema, so the skill guidance had drifted from the preferred pattern and would lead agents to write string-literal release statuses.Changes
Updated the skill in two places to direct agents to use the
ReleaseStatusenum instead of string literals:ReleaseStatusfromposthog.schemaand usingReleaseStatus.ALPHA/ReleaseStatus.BETA/ReleaseStatus.GA.ReleaseStatusenum, never a string literal".Docs/skill-only change — no production code touched.
How did you test this code?
I'm an agent. This is a documentation-only change to a skill file (no code), so there are no automated tests to run. Verified the referenced
ReleaseStatusenum exists inposthog/schema.pyand matches the enum-based usage in existing sources.Automatic notifications
🤖 Agent context
Authored by Claude Code (Opus 4.8) at Tom Owers' request. The change aligns the warehouse-sources skill with the
ReleaseStatusenum pattern already adopted by several sources in the repo, replacing the older string-literal guidance. Confirmed the enum (ALPHA/BETA/GA) inposthog/schema.pyand the existing enum-based usages before editing.