Skip to content

chore: use ReleaseStatus enum for warehouse source release status#60893

Merged
Gilbert09 merged 2 commits into
masterfrom
posthog-code/warehouse-source-releasestatus-enum
Jun 2, 2026
Merged

chore: use ReleaseStatus enum for warehouse source release status#60893
Gilbert09 merged 2 commits into
masterfrom
posthog-code/warehouse-source-releasestatus-enum

Conversation

@Gilbert09
Copy link
Copy Markdown
Member

Problem

The implementing-warehouse-sources skill documented setting releaseStatus with bare string literals ("alpha", "beta", "ga"). Newer sources (e.g. resend, plain, revenuecat, customer_io) already use the ReleaseStatus enum from posthog.schema, so the skill guidance had drifted from the preferred pattern and would lead agents to write string-literal release statuses.

Changes

Updated the skill in two places to direct agents to use the ReleaseStatus enum instead of string literals:

  • Step 13 ("Release status") — now instructs importing ReleaseStatus from posthog.schema and using ReleaseStatus.ALPHA / ReleaseStatus.BETA / ReleaseStatus.GA.
  • The "Release status" checklist — each item references the enum members, plus a new explicit item: "releaseStatus set via the ReleaseStatus enum, never a string literal".

Docs/skill-only change — no production code touched.

How did you test this code?

I'm an agent. This is a documentation-only change to a skill file (no code), so there are no automated tests to run. Verified the referenced ReleaseStatus enum exists in posthog/schema.py and matches the enum-based usage in existing sources.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

🤖 Agent context

Authored by Claude Code (Opus 4.8) at Tom Owers' request. The change aligns the warehouse-sources skill with the ReleaseStatus enum pattern already adopted by several sources in the repo, replacing the older string-literal guidance. Confirmed the enum (ALPHA/BETA/GA) in posthog/schema.py and the existing enum-based usages before editing.

Update the implementing-warehouse-sources skill so new sources set
releaseStatus via the ReleaseStatus enum (ALPHA/BETA/GA) imported from
posthog.schema rather than bare string literals.

Generated-By: PostHog Code
Task-Id: 59df82d8-15e8-4a33-b091-d7e5182d4f5c
Copilot AI review requested due to automatic review settings June 1, 2026 12:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

Hey @Gilbert09! 👋

It looks like your git author email on this PR isn't your @posthog.com address (owerstom@gmail.com). Since you're on the PostHog team, it's worth pointing your local git author email at your @posthog.com address. Why it matters:

  • Consistent work identity in git history — internal tooling that attributes commits to team members keys off your @posthog.com address.
  • Keeps team contributions easy to tell apart from external community ones when scanning history.

You can fix it for this repo with:

git config user.email "you@posthog.com"

Or set it globally with git config --global user.email "you@posthog.com". No need to redo this PR — just a nudge for next time. 🙂

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 1, 2026

Reviews (1): Last reviewed commit: "chore: use ReleaseStatus enum for wareho..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the implementing-warehouse-sources agent skill documentation to align warehouse source releaseStatus guidance with the codebase’s preferred ReleaseStatus enum usage (instead of string literals), reducing drift between docs and current source implementations.

Changes:

  • Update Step 13 (“Release status”) to recommend using ReleaseStatus enum members (ALPHA/BETA/GA) rather than "alpha"/"beta"/"ga".
  • Update the “Release status” checklist to reference enum usage and add an explicit “never a string literal” reminder.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .agents/skills/implementing-warehouse-sources/SKILL.md Outdated
Comment thread .agents/skills/implementing-warehouse-sources/SKILL.md Outdated
Fix an invalid Python import example (`...` placeholder) and reword the
guidance so it no longer implies releaseStatus must always be set — "when
set, use the enum" — keeping it consistent with leaving releaseStatus unset
for GA.

Generated-By: PostHog Code
Task-Id: 59df82d8-15e8-4a33-b091-d7e5182d4f5c
@Gilbert09 Gilbert09 merged commit 90797d7 into master Jun 2, 2026
147 checks passed
@Gilbert09 Gilbert09 deleted the posthog-code/warehouse-source-releasestatus-enum branch June 2, 2026 10:20
@deployment-status-posthog
Copy link
Copy Markdown

deployment-status-posthog Bot commented Jun 2, 2026

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-06-02 10:56 UTC Run
prod-us ✅ Deployed 2026-06-02 11:09 UTC Run
prod-eu ✅ Deployed 2026-06-02 11:16 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants