chore(cymbal-resolution): wire image into deploy matrix#60899
Merged
Conversation
Contributor
|
Hey @hpouillot! 👋 It looks like your git author email on this PR isn't your
You can fix it for this repo with: git config user.email "you@posthog.com"Or set it globally with |
Contributor
|
Reviews (1): Last reviewed commit: "Merge branch 'master' into hp/cymbal-res..." | Re-trigger Greptile |
New commits pushed (delta classified non_trivial_delta) — stamphog approval dismissed; re-review running automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
cymbal-resolutionservice was not yet wired into the rust docker build deploy matrix, so the image was not being built and pushed for deploys.Changes
cymbal-resolutionentry to the deploy matrix in.github/workflows/rust-docker-build.ymlso the image is built and the chart digest is updated.info!log ofmax_concurrent_requestsinrust/cymbal-resolution/src/main.rsto make pod config observable and to bump the image build.How did you test this code?
I'm an agent — no manual testing. Relying on CI to validate the workflow change and image build. Existing cymbal-resolution unit tests cover the binary; the added log line is a pure additive
tracing::info!with no behavior change.Publish to changelog?
no
🤖 Agent context
Authored with Claude Code (Opus 4.7). The user asked for a small change to
cymbal-resolutionto force a rebuild after wiring the service into the deploy matrix; we added a startup log line that also surfaces the configured concurrency limit, which is useful info to keep. Also did a quick audit of the logging surface at info level for prod noise — no per-request info logs on the resolve hot path. Flaggedrust/cymbal/src/symbol_store/saving.rssymbol-fetch info logs as a separate, pre-existing noise concern for follow-up.