Skip to content

chore(cymbal-resolution): wire image into deploy matrix#60899

Merged
hpouillot merged 4 commits into
masterfrom
hp/cymbal-resolution-deploy-matrix
Jun 1, 2026
Merged

chore(cymbal-resolution): wire image into deploy matrix#60899
hpouillot merged 4 commits into
masterfrom
hp/cymbal-resolution-deploy-matrix

Conversation

@hpouillot
Copy link
Copy Markdown
Contributor

Problem

The cymbal-resolution service was not yet wired into the rust docker build deploy matrix, so the image was not being built and pushed for deploys.

Changes

  • Add cymbal-resolution entry to the deploy matrix in .github/workflows/rust-docker-build.yml so the image is built and the chart digest is updated.
  • Add a startup info! log of max_concurrent_requests in rust/cymbal-resolution/src/main.rs to make pod config observable and to bump the image build.

How did you test this code?

I'm an agent — no manual testing. Relying on CI to validate the workflow change and image build. Existing cymbal-resolution unit tests cover the binary; the added log line is a pure additive tracing::info! with no behavior change.

Publish to changelog?

no

🤖 Agent context

Authored with Claude Code (Opus 4.7). The user asked for a small change to cymbal-resolution to force a rebuild after wiring the service into the deploy matrix; we added a startup log line that also surfaces the configured concurrency limit, which is useful info to keep. Also did a quick audit of the logging surface at info level for prod noise — no per-request info logs on the resolve hot path. Flagged rust/cymbal/src/symbol_store/saving.rs symbol-fetch info logs as a separate, pre-existing noise concern for follow-up.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

Hey @hpouillot! 👋

It looks like your git author email on this PR isn't your @posthog.com address (hpouillot@gmail.com). Since you're on the PostHog team, it's worth pointing your local git author email at your @posthog.com address. Why it matters:

  • Consistent work identity in git history — internal tooling that attributes commits to team members keys off your @posthog.com address.
  • Keeps team contributions easy to tell apart from external community ones when scanning history.

You can fix it for this repo with:

git config user.email "you@posthog.com"

Or set it globally with git config --global user.email "you@posthog.com". No need to redo this PR — just a nudge for next time. 🙂

@assign-reviewers-posthog assign-reviewers-posthog Bot requested a review from a team June 1, 2026 13:07
@hpouillot hpouillot removed the request for review from a team June 1, 2026 13:08
@hpouillot hpouillot added the stamphog Request AI review from stamphog label Jun 1, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 1, 2026

Reviews (1): Last reviewed commit: "Merge branch 'master' into hp/cymbal-res..." | Re-trigger Greptile

github-actions[bot]
github-actions Bot previously approved these changes Jun 1, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial additive log line, no risk.

@hpouillot hpouillot enabled auto-merge (squash) June 1, 2026 13:11
@github-actions github-actions Bot dismissed their stale review June 1, 2026 13:24

New commits pushed (delta classified non_trivial_delta) — stamphog approval dismissed; re-review running automatically.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial additive log line, no risk.

@hpouillot hpouillot merged commit 59a0390 into master Jun 1, 2026
171 checks passed
@hpouillot hpouillot deleted the hp/cymbal-resolution-deploy-matrix branch June 1, 2026 13:36
@deployment-status-posthog
Copy link
Copy Markdown

deployment-status-posthog Bot commented Jun 1, 2026

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-06-01 14:14 UTC Run
prod-us ✅ Deployed 2026-06-01 14:35 UTC Run
prod-eu ✅ Deployed 2026-06-01 15:32 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stamphog Request AI review from stamphog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant