fix(logs): stop closed modals leaking react-modal portals on unmount#60905
Merged
jonmcwest merged 1 commit intoJun 1, 2026
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Reviews (1): Last reviewed commit: "fix(logs): stop closed modals leaking re..." | Re-trigger Greptile |
Contributor
|
Size Change: 0 B Total Size: 80.9 MB ℹ️ View Unchanged
|
jonmcwest
deleted the
06-01-fix_logs_stop_closed_modals_leaking_react-modal_portals_on_unmount
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
react-modal(used underLemonModal/LemonDrawer) mounts a portal container the moment it renders, even when the modal is closed. React 18 binds its full delegated event surface to that container, meaning any modal that is rendered-but-closed leaks that container and its listeners on every mount/unmount (e.g. during navigation). The logs viewer and saved views modals were both affected by this.Changes
Introduces a
useKeepMountedWhileOpenhook that gates whether a modal component renders at all:false(preventing render) until the modal is opened for the first time, so a never-opened modal mounts no portal.trueimmediately when opened.truefor a 300 ms grace period after close, allowingreact-modal'scloseTimeoutMSexit animation to complete before unmounting.The hook is applied to
LogsViewerModal,SaveViewModal, andSavedViewsModal.This follows the same portal-gating approach used for Popover/Radix in #54126.
How did you test this code?
Open and close the logs viewer modal and saved views modal and verify that animations complete correctly and no console errors appear. Confirm that modals that are never opened do not mount any portal containers.
Automatic notifications
Docs update