fix(data-warehouse): restore sync method column for non-SQL sources#60908
Merged
Conversation
👥 Auto-assigned reviewersSkipped a review request for |
Contributor
|
Reviews (1): Last reviewed commit: "fix(data-warehouse): restore sync method..." | Re-trigger Greptile |
danielcarletti
approved these changes
Jun 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the Sync method (and related sync configuration) columns in the data warehouse “Select tables to import” step for non-SQL (REST/webhook) sources by separating column-selection visibility from sync-configuration visibility.
Changes:
- Splits the previous
shouldShowSyncColumnsgate into:shouldShowSyncColumns = !isDirectQueryMode(sync field / primary key / sync method)shouldShowColumnSelection = !isDirectQueryMode && !!selectedConnector?.supportsColumnSelection(columns picker)
- Ensures the Columns column remains restricted to SQL sources that support column selection.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+88
to
90
| const shouldShowSyncColumns = !isDirectQueryMode | ||
| const shouldShowColumnSelection = !isDirectQueryMode && !!selectedConnector?.supportsColumnSelection | ||
|
|
Contributor
|
Size Change: 0 B Total Size: 80.9 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the new source wizard's "Select tables to import" step, the Sync method column disappeared for non-SQL sources (Stripe, Hubspot, and any REST-based source). Users could no longer choose the sync method (full refresh vs incremental) per table during source setup.
This was a regression from #60155, which added per-table column selection for SQL sources (MySQL, MSSQL, BigQuery, Snowflake, Redshift, Postgres).
Changes
The column-selection PR tightened the existing
shouldShowSyncColumnsgate to!isDirectQueryMode && !!selectedConnector?.supportsColumnSelection. That variable also controls the Sync field, Primary key, and Sync method columns — so gating it behindsupportsColumnSelection(which isfalsefor all non-SQL sources) hid those columns everywhere except SQL sources.This splits the gate into two:
shouldShowSyncColumns = !isDirectQueryMode— restores the original behavior for Sync field, Primary key, and Sync method (shown for all non-direct-query sources).shouldShowColumnSelection = !isDirectQueryMode && !!selectedConnector?.supportsColumnSelection— keeps the new Columns column correctly scoped to SQL sources, which was the intent of feat(data-warehouse): column selection on MySQL, MSSQL, BigQuery, Snowflake, Redshift #60155.How did you test this code?
I'm an agent (Claude Code). I traced the regression to the gating change in
SchemaForm.tsx, confirmed viagit showthat #60155 was the source, and verifiedsupports_column_selectiondefaults toFalsein the source base config (only SQL sources set itTrue). I did not run the wizard manually — a quick manual check that the Sync method picker renders and works for a Stripe source would be worth doing before merge. No automated tests cover this column-gating logic.🤖 Agent context
Authored with Claude Code. The user reported the missing sync method picker for Stripe; I located the table-selection step (
SchemaForm), bisected the cause to the over-broadshouldShowSyncColumnsgate introduced in #60155, and decoupled the column-selection gate from the sync-method/sync-field/primary-key gate rather than reverting the column-selection feature.