feat(devex): polish auto-assigned reviewers comment#60935
Merged
Conversation
Follow-up to the reviewer-assignment refactor. Make the skipped-owner comment easier for a human to scan: - list each skipped owner on its own bullet with its matched rule instead of a single run-on sentence that got unreadable past 3-4 owners - use the 👀 emoji to match the "self-assign if you'd like a look" framing - drop em/en dashes from the script and its comment output
Contributor
|
Reviews (1): Last reviewed commit: "feat(devex): polish auto-assigned review..." | Re-trigger Greptile |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR polishes the informational “auto-assigned reviewers” PR comment produced by .github/scripts/assign-reviewers.js, improving scanability when multiple soft owners are skipped while keeping reviewer assignment behavior unchanged.
Changes:
- Reformat skipped/soft owners from a single run-on sentence into a per-owner bullet list including the matched rule.
- Update the heading to “### 👀 Auto-assigned reviewers” and adjust copy/punctuation to avoid em/en dashes.
- Update the Jest test to assert the new bullet output format.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/scripts/assign-reviewers.js | Reworks the generated comment text to use a bullet list for skipped owners and updates heading/copy punctuation. |
| .github/scripts/assign-reviewers.test.js | Updates the comment-format assertion to match the new bullet rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Piccirello
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The auto-assigned reviewers comment (added in #60648) packs every skipped owner into a single run-on sentence.
Once a PR skips 4+ owners that becomes hard for a human to scan, and the prose used em/en dashes.
Changes
The comment now renders like:
No behavior change to who actually gets requested for review — this is comment copy/formatting only.
How did you test this code?
I'm an agent. I ran the existing jest suite for this script locally (
.github/scripts/assign-reviewers.test.js, 30/30 passing) and oxlint/oxfmt clean. I also rendered the comment for the 4-skipped-owner case to confirm the bullet output. Updated the one assertion that checked the old sentence format to expect the new bullet format. No manual end-to-end run of the workflow (it only executes frommasteron PR open).Automatic notifications
🤖 Agent context
Authored by Claude Code at the request of @webjunkie as a follow-up to #60648 (which merged the footprint-based reviewer filtering).
Iteration that led here: the live comment on a real multi-team PR read poorly as a single sentence once many owners were skipped. We considered a markdown table but rejected it — file/line counts aren't actionable without the underlying file list, which is too long to include — so the matched CODEOWNERS rule is the only locator shown. Landed on a plain bullet list per owner. Emoji and dash removal were explicit requests.
The original branch had already squash-merged via #60648, so this is a fresh branch cut from current
mastercarrying only the two-file comment polish.Agent-authored — requires human review, not self-merged.
Generated by Claude Code