Skip to content

feat(devex): polish auto-assigned reviewers comment#60935

Merged
webjunkie merged 1 commit into
masterfrom
claude/reviewer-comment-polish
Jun 1, 2026
Merged

feat(devex): polish auto-assigned reviewers comment#60935
webjunkie merged 1 commit into
masterfrom
claude/reviewer-comment-polish

Conversation

@webjunkie
Copy link
Copy Markdown
Contributor

Problem

The auto-assigned reviewers comment (added in #60648) packs every skipped owner into a single run-on sentence.
Once a PR skips 4+ owners that becomes hard for a human to scan, and the prose used em/en dashes.

Changes

  • List each skipped owner on its own bullet with its matched rule, instead of one long comma-joined sentence. Still no table and no file/line counts (a bare "10 files" without the file list tells a reader nothing actionable).
  • Use the 👀 emoji in the heading to match the "self-assign if you'd like a look" framing.
  • Drop em/en dashes from the script and its rendered comment output.

The comment now renders like:

👀 Auto-assigned reviewers

These soft owners were skipped because they only have minor changes here. Nothing blocks merge, so self-assign if you'd like a look:

  • @PostHog/team-product-analytics (products/dashboards/**)
  • @PostHog/logs (products/logs/**)
  • @PostHog/team-data-stack (products/data_warehouse/**)

Soft owners come from [CODEOWNERS-soft] and each product's product.yaml. Generated files and lockfiles are ignored when deciding ownership.

No behavior change to who actually gets requested for review — this is comment copy/formatting only.

How did you test this code?

I'm an agent. I ran the existing jest suite for this script locally (.github/scripts/assign-reviewers.test.js, 30/30 passing) and oxlint/oxfmt clean. I also rendered the comment for the 4-skipped-owner case to confirm the bullet output. Updated the one assertion that checked the old sentence format to expect the new bullet format. No manual end-to-end run of the workflow (it only executes from master on PR open).

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

🤖 Agent context

Authored by Claude Code at the request of @webjunkie as a follow-up to #60648 (which merged the footprint-based reviewer filtering).

Iteration that led here: the live comment on a real multi-team PR read poorly as a single sentence once many owners were skipped. We considered a markdown table but rejected it — file/line counts aren't actionable without the underlying file list, which is too long to include — so the matched CODEOWNERS rule is the only locator shown. Landed on a plain bullet list per owner. Emoji and dash removal were explicit requests.

The original branch had already squash-merged via #60648, so this is a fresh branch cut from current master carrying only the two-file comment polish.

Agent-authored — requires human review, not self-merged.


Generated by Claude Code

Follow-up to the reviewer-assignment refactor. Make the skipped-owner
comment easier for a human to scan:

- list each skipped owner on its own bullet with its matched rule instead
  of a single run-on sentence that got unreadable past 3-4 owners
- use the 👀 emoji to match the "self-assign if you'd like a look" framing
- drop em/en dashes from the script and its comment output
Copilot AI review requested due to automatic review settings June 1, 2026 14:50
@webjunkie webjunkie requested a review from a team as a code owner June 1, 2026 14:50
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 1, 2026

Reviews (1): Last reviewed commit: "feat(devex): polish auto-assigned review..." | Re-trigger Greptile

@webjunkie webjunkie enabled auto-merge (squash) June 1, 2026 14:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR polishes the informational “auto-assigned reviewers” PR comment produced by .github/scripts/assign-reviewers.js, improving scanability when multiple soft owners are skipped while keeping reviewer assignment behavior unchanged.

Changes:

  • Reformat skipped/soft owners from a single run-on sentence into a per-owner bullet list including the matched rule.
  • Update the heading to “### 👀 Auto-assigned reviewers” and adjust copy/punctuation to avoid em/en dashes.
  • Update the Jest test to assert the new bullet output format.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/scripts/assign-reviewers.js Reworks the generated comment text to use a bullet list for skipped owners and updates heading/copy punctuation.
.github/scripts/assign-reviewers.test.js Updates the comment-format assertion to match the new bullet rendering.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@webjunkie webjunkie merged commit 87829a9 into master Jun 1, 2026
145 of 146 checks passed
@webjunkie webjunkie deleted the claude/reviewer-comment-polish branch June 1, 2026 20:39
@deployment-status-posthog
Copy link
Copy Markdown

deployment-status-posthog Bot commented Jun 1, 2026

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-06-01 21:12 UTC Run
prod-us ✅ Deployed 2026-06-01 21:29 UTC Run
prod-eu ✅ Deployed 2026-06-01 21:33 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants