feat(llma): show person, tools, and error highlighting on sessions overview#60940
Merged
Conversation
mp-hog
added
the
skip-inkeep-docs
Contributor
|
Size Change: +2.86 kB (0%) Total Size: 81 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
posthog/hogql_queries/ai/test/test_sessions_aggregation.py:417-462
**Prefer parameterised tests for related cases**
`test_session_aggregates_distinct_tools` and `test_session_with_no_tools_returns_empty_list` both exercise the `tools` column with different inputs (present vs absent tools). Per the team's standard these would ideally be a single parameterised test. At the moment they share no fixture setup, so a future maintainer adding a third variant must remember to add yet another method rather than extending a parameter list.
Reviews (1): Last reviewed commit: "Reduce comments" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
Radu-Raicea
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The sessions table showed less information than the traces table.
Changes
How did you test this code?