fix(ci): use !cancelled() gate pattern for LLM Services roll-up#60950
Merged
Conversation
Replace `if: always()` with `if: ${{ !cancelled() }}` on the
llm_services_tests gate job so that concurrency-evicted runs skip the
gate entirely instead of reporting failure.
Change the llm-gateway result check from a != success/skipped allowlist
to an explicit == failure check. This means cancelled upstream jobs no
longer cause the gate to fail.
This preserves the master dedup concurrency group (github.ref fallback)
while fixing the root cause: the gate treating cancelled jobs as
failures.
Closes the same class of issue as Security CI #60298.
👥 Auto-assigned reviewersSkipped a review request for |
Contributor
|
Reviews (1): Last reviewed commit: "fix(ci): use !cancelled() gate pattern f..." | Re-trigger Greptile |
rnegron
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llm_services_testsgate job to use!cancelled()instead ofalways(), and check for explicitfailurerather than!= success/skippedgithub.ref) while preventing concurrency-evicted runs from reporting false failuresSupersedes #60796 based on feedback from @rnegron — the root cause is the gate condition, not the concurrency group. This also fixes the same class of issue seen in Security CI (#60298).
Note
Created by Mendral. Tag @mendral-app with feedback or questions.