fix(tasks): gate dropped slack post behind temporal patch#60956
Merged
Conversation
#60923 removed the redundant `post_slack_update` activity that ran right after sandbox provisioning. Doing so unconditionally broke replay of in-flight ProcessTaskWorkflow executions: their histories scheduled `post_slack_update` at that point, while the new code scheduled `emit_progress_activity` next, surfacing TMPRL1100 nondeterminism errors in production. Restore the call behind `workflow.patched(...)` so post-rollout executions skip it (keeping #60923's intent) while replays of pre-rollout histories still schedule it. Follows the two-step patch lifecycle already documented in this workflow.
Contributor
|
Reviews (1): Last reviewed commit: "fix(tasks): gate dropped slack post behi..." | Re-trigger Greptile |
VojtechBartos
approved these changes
Jun 1, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
⏭️ Skipped snapshot commit because branch advanced to The new commit will trigger its own snapshot update workflow. If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:
|
MattPua
pushed a commit
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Production is throwing
[TMPRL1100] Nondeterminism error: Activity type of scheduled event 'post_slack_update' does not match activity type of activity command 'emit_progress_activity'#60923 ("drop duplicate slack progress post after sandbox provisioning") removed an
await self._post_slack_update()call that sat between sandbox provisioning and the agent-start progress emit. Removing an activity call from a workflow is a backwards-incompatible change