Skip to content

feat(capture): integrate v1 router in critical path#61029

Merged
eli-r-ph merged 1 commit into
masterfrom
eli.r/cap-v1-router-enable
Jun 2, 2026
Merged

feat(capture): integrate v1 router in critical path#61029
eli-r-ph merged 1 commit into
masterfrom
eli.r/cap-v1-router-enable

Conversation

@eli-r-ph
Copy link
Copy Markdown
Contributor

@eli-r-ph eli-r-ph commented Jun 1, 2026

Problem

Time to enable the capture v1 Axum router in prod deploys. A separate deployment cfg PR will enable this (dev env first) this PR should land as a no-op

Changes

  • Wire up Router injection & related test updates
  • Gating mechanism for enablement is now env presence of v1 sink configs,, as intended

How did you test this code?

Locally and in CI;

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Docs update

🤖 Agent context

@eli-r-ph eli-r-ph requested a review from a team June 1, 2026 21:58
@eli-r-ph eli-r-ph self-assigned this Jun 1, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 1, 2026

Reviews (1): Last reviewed commit: "wire up capture v1 kafka router; begin u..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@jose-sequeira jose-sequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eli-r-ph eli-r-ph merged commit cfd269f into master Jun 2, 2026
178 checks passed
@eli-r-ph eli-r-ph deleted the eli.r/cap-v1-router-enable branch June 2, 2026 16:47
@deployment-status-posthog
Copy link
Copy Markdown

deployment-status-posthog Bot commented Jun 2, 2026

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-06-02 17:40 UTC Run
prod-us ✅ Deployed 2026-06-02 18:08 UTC Run
prod-eu ✅ Deployed 2026-06-02 18:13 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants