fix(replay-vision): link observation breadcrumb to its scanner#61033
Merged
ksvat merged 1 commit intoJun 1, 2026
Conversation
Clicking back from an observation detail page went to the Replay vision
home instead of the scanner the observation belongs to, so there was no
quick way to drill into that scanner's other observations.
The breadcrumb trail was hardcoded to `Replay vision → Observation`. It now
inserts a scanner crumb in between (`Replay vision → {scanner} → Observation`)
that links to the scanner page. The scanner id and name are pushed to the
scene logic by replayObservationLogic once the observation loads; scanner_id
is a top-level field on every observation, so this also works for pending and
failed observations, with the name falling back to "Scanner" when there is no
snapshot yet. The context clears when navigating between observations so a
stale scanner never briefly shows.
Generated-By: PostHog Code
Task-Id: fb62321a-5c49-4102-b367-6af893652809
assign-reviewers-posthog
Bot
requested review from
a team,
TueHaulund,
arnohillen and
fasyy612
and removed request for
a team
Contributor
|
Reviews (1): Last reviewed commit: "fix(replay-vision): link observation bre..." | Re-trigger Greptile |
Contributor
|
Size Change: 0 B Total Size: 80.9 MB ℹ️ View Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking back from an observation detail page (
/replay-vision/observations/:id) went to the Replay vision home rather than the scanner the observation belongs to. There was no quick way to get from one observation back to its scanner to drill into that scanner's other observations.Changes
The observation scene's breadcrumb trail was hardcoded to
Replay vision → Observation. It now inserts the parent scanner in between:Replay vision → {scanner name} → Observation
The scanner crumb links to the scanner page (
urls.replayVision(scannerId)). Implementation:replayObservationLogicpushes the observation'sscanner_idand snapshot name to the scene logic once the observation loads.scanner_idis a top-level field on every observation, so the link also works for pending/failed observations; the name falls back to "Scanner" when there's no snapshot yet.replayObservationSceneLogicholds that context in a reducer and builds the three-level breadcrumb. The context clears when navigating between observations, so a stale scanner never briefly shows.How did you test this code?
I'm an agent (PostHog Code), so automated checks only:
pnpm --filter=@posthog/frontend format— cleanpnpm --filter=@posthog/frontend typescript:check— no errors inreplay_vision(kea types regenerated viatypegen:write)Not yet clicked through in a browser; the breadcrumb/back behavior should be verified manually before merge.
🤖 Agent context
Authored with PostHog Code (Claude) during a Replay Vision dogfooding session, after noticing "back" from an observation skipped the scanner. Breadcrumbs are sourced only from the active scene logic, and the observation data lives in a separately keyed data logic, so the data logic pushes scanner context to the scene logic on load (both share
tabId) — chosen over re-fetching in the scene logic or keying the scene by observation id. No API or model changes. Requires human review.Created with PostHog Code