revert(dmat): revert dmat_string column wiring (#59681, #61036)#61041
Conversation
This reverts commit ca85437.
|
Hey @fuziontech! 👋 It looks like your git author email on this PR isn't your
You can fix it for this repo with: git config user.email "you@posthog.com"Or set it globally with |
|
Reviews (1): Last reviewed commit: "Revert "feat(dmat): re-apply dmat_string..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
This PR reverts the dmat_string ClickHouse “wiring” that was previously added for the events ingestion pipeline, including removing the migration that recreated Kafka/MV tables and altered schemas to project dmat_string_* columns.
Changes:
- Deletes the ClickHouse migration
0267_wire_up_existing_dmat_string_columns, undoing the schema-wiring steps it introduced. - Reverts
posthog/models/event/sql.pyadditions by removing the JSON-table/MV name + DROP SQL constants and by removing theon_clustertoggle fromKAFKA_EVENTS_TABLE_JSON_SQL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| posthog/models/event/sql.py | Removes constants and restores KAFKA_EVENTS_TABLE_JSON_SQL to a no-arg form that always uses the default ON_CLUSTER_CLAUSE() behavior. |
| posthog/clickhouse/migrations/0267_wire_up_existing_dmat_string_columns.py | Deletes the migration that performed the dmat_string pipeline/schema wiring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎭 Playwright report
These issues are not necessarily caused by your changes. |
Problem
This reverts the
dmat_stringcolumn wiring introduced in #59681 and the follow-up fix in #61036.Changes
Reverts both PRs:
fix(clickhouse): writable_events doesn't exist on DATA(a one-line fix to the0267migration)feat(dmat): re-apply dmat_string column wiring, scoped to data nodesNet effect on
master:0267_wire_up_existing_dmat_string_columnsClickHouse migration.posthog/models/event/sql.py(KAFKA_EVENTS_JSON_TABLE,EVENTS_JSON_MV, theDROP_*SQL constants, and theon_clusterparameter onKAFKA_EVENTS_TABLE_JSON_SQL).max_migration.txtis intentionally left pointing at0268_property_values_kafka_num_consumers— the latest migration, which landed after0267and is unrelated to this revert. Only the0267file is removed.How did you test this code?
I'm an agent (Claude Code). No manual testing was performed. Verification done:
0267is the only migration file touched and that the newer0268migration (andmax_migration.txtpointing at it) is preserved.sql.py(DROP_KAFKA_EVENTS_JSON_TABLE_SQL,DROP_EVENTS_JSON_MV_SQL,KAFKA_EVENTS_JSON_TABLE,EVENTS_JSON_MV) outside the deleted migration — none remain.🤖 Agent context
Authored by Claude Code on request to revert #61036 and #59681.
Approach: reverted the two squash-merge commits newest-first via
git revert. The revert of #59681 conflicted onmax_migration.txtbecause a later migration (0268) had already advanced the pointer past0267; resolved by keeping0268rather than rolling the pointer back to0266, so only the0267migration is removed and the unrelated0268migration stays intact.